-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "setting up prettier" in CONTRIBUTING.md #46310
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Pinging @elastic/kibana-operations |
Thanks @sainthkh! small comment above |
Removed contents about prettier. Still, I have a question about prettier: It is not wrong to install 'prettier' plugin on VS Code and use them whenever file is saved. Right? I guess I became curious about this because currently |
Co-Authored-By: Jonathan Budzenski <jon@budzenski.me>
I wouldn't recommend using the prettierrc plugin in vscode - it will read the prettierrc but we have overrides in places that eslint will manage differently. roughly the workflow is eslint config + prettier - (rules where eslint overrides prettier) |
@elasticmachine merge upstream |
nice, thanks @sainthkh. retest |
OK. I'll turn prettier plugin off. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe it's best to explicitly mention that the prettier plugin shouldn't be used in Kibana. Primarily because not all files are supposed to be prettierified and that configuration is in the eslint config not in a .prettierignore
file or something (so the prettier plugin applies to too many files).
@spalger I agree. So, I've added a warning to the VS code setting section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retest |
This comment has been minimized.
This comment has been minimized.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elasticmachine merge upstream - sorry for all the pings, jenkins went down this time. one more time, I'll override if we're still red
This comment has been minimized.
This comment has been minimized.
@elasticmachine merge upstream |
Merging since this is docs. |
Co-Authored-By: Jonathan Budzenski <jon@budzenski.me>
7.x/7.5: 88a4db0 |
Summary
In #16514, prettier was set up for Kibana. And styleguide recommends to use it, but prettier wasn't mentioned in CONTRIBUTING.md.
So, I've added some explanation and setup guide.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers