Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase breadcrumb max setting #46595

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Increase breadcrumb max setting #46595

merged 2 commits into from
Oct 1, 2019

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Sep 25, 2019 •
edited
Loading

Closes #43270

Before:
image

After:
image

cc @joshdover @cchaos

@sorenlouv sorenlouv requested a review from a team as a code owner September 25, 2019 15:16
@sorenlouv sorenlouv mentioned this pull request Sep 25, 2019
Closed
dgieselaar
dgieselaar approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv
Copy link
Member Author

Okay with @elastic/kibana-platform ?

@sorenlouv
Copy link
Member Author

@elasticmachine merge upstream

rudolf
rudolf approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the code changes. Should we get eui-design to review?

@sorenlouv
Copy link
Member Author

Thanks @rudolf !

@cchaos suggested to make the change so I think EUI are in on it :)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv sorenlouv merged commit dca6b3b into master Oct 1, 2019
@sorenlouv sorenlouv deleted the increase-breadcrumb-max branch October 1, 2019 12:49
@sorenlouv sorenlouv mentioned this pull request Oct 1, 2019
Merged
sorenlouv added a commit that referenced this pull request Oct 1, 2019
@sorenlouv
Increase breadcrumb max setting (#46595) (#47034)
86db2ab
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@smith
Copy link
Contributor

smith commented Oct 21, 2019

Test plan: verified ✅

image

@smith smith added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@rudolf rudolf rudolf approved these changes

@joshdover joshdover Awaiting requested review from joshdover

Assignees
No one assigned
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:enhancement v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Breadcrumb is truncated prematurely
5 participants
@sorenlouv @elasticmachine @smith @dgieselaar @rudolf