Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI / ML] Add partitioning to log entry rate job #46690

Merged

Conversation

Kerry350
Copy link
Contributor

Summary

Closes #46583 by adding partitioning to the log entry rate job, using the ECS event.dataset field.

cc @elastic/infra-logs-ui

@Kerry350 Kerry350 added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 :Logs UI labels Sep 26, 2019
@Kerry350 Kerry350 requested review from sophiec20, grabowskit and a team September 26, 2019 11:09
@Kerry350 Kerry350 self-assigned this Sep 26, 2019
@Kerry350 Kerry350 added the release_note:skip Skip the PR/issue when compiling release notes label Sep 26, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual inspection of the results written by ML looks good. Of course, the data returned by our log entry rate results api will be incorrect until it has been adapted (see #46459).

@weltenwort
Copy link
Member

One thought just appeared: Even though we haven't shipped this feature, we might want to increment the job revision in the custom_settings to ease our own development process.

Copy link
Contributor

@sophiec20 sophiec20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Kerry350 Kerry350 merged commit bf9dcde into elastic:master Sep 30, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Sep 30, 2019
Kerry350 added a commit that referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Add partitioning to log rate job for the analysis feature
4 participants