Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to 14.4.0 #46949

Merged
merged 3 commits into from
Oct 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"@babel/register": "^7.5.5",
"@elastic/charts": "^12.0.2",
"@elastic/datemath": "5.0.2",
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"@elastic/filesaver": "1.1.2",
"@elastic/good": "8.1.1-kibana2",
"@elastic/numeral": "2.3.3",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,7 @@
* under the License.
*/
import React from 'react';
import {
// @ts-ignore
EuiCard,
EuiFlexItem,
EuiFlexGroup,
EuiFormRow,
} from '@elastic/eui';
import { EuiCard, EuiFlexItem, EuiFlexGroup, EuiFormRow } from '@elastic/eui';

import { Subscription } from 'rxjs';
import { EuiButton } from '@elastic/eui';
Expand Down Expand Up @@ -96,7 +90,12 @@ export class ContactCardEmbeddableComponent extends React.Component<Props, State

render() {
return (
<EuiCard textAlign="left" title={this.state.fullName} footer={this.getCardFooterContent()} />
<EuiCard
textAlign="left"
title={this.state.fullName}
footer={this.getCardFooterContent()}
description=""
/>
);
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"license": "Apache-2.0",
"dependencies": {
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"react": "^16.8.0",
"react-dom": "^16.8.0"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"license": "Apache-2.0",
"dependencies": {
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"react": "^16.8.0"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"license": "Apache-2.0",
"dependencies": {
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"react": "^16.8.0"
},
"scripts": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"license": "Apache-2.0",
"dependencies": {
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"react": "^16.8.0"
},
"scripts": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"license": "Apache-2.0",
"dependencies": {
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"react": "^16.8.0",
"react-dom": "^16.8.0"
}
Expand Down
1 change: 0 additions & 1 deletion typings/@elastic/eui/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ declare module '@elastic/eui' {
export const EuiDescribedFormGroup: React.SFC<any>;
export const EuiCodeEditor: React.SFC<any>;
export const Query: any;
export const EuiCard: any;

export interface EuiTableCriteria {
page: { index: number; size: number };
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
import {
// @ts-ignore unconverted EUI component
EuiCard,
EuiIcon,
} from '@elastic/eui';
import { EuiCard, EuiIcon } from '@elastic/eui';
import { TagList } from '../tag_list/';

export interface Props {
Expand Down Expand Up @@ -45,7 +41,7 @@ export const ElementCard = ({ title, description, image, tags = [], onClick, ...
description={description}
footer={<TagList tags={tags} tagType={tagType} />}
image={image}
icon={image ? null : <EuiIcon type="canvasApp" size="xxl" />}
icon={image ? undefined : <EuiIcon type="canvasApp" size="xxl" />}
onClick={onClick}
{...rest}
/>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion x-pack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
"@babel/runtime": "^7.5.5",
"@elastic/ctags-langserver": "^0.1.10",
"@elastic/datemath": "5.0.2",
"@elastic/eui": "14.3.0",
"@elastic/eui": "14.4.0",
"@elastic/javascript-typescript-langserver": "^0.3.3",
"@elastic/lsp-extension": "^0.1.2",
"@elastic/maki": "6.1.0",
Expand Down
1 change: 0 additions & 1 deletion x-pack/typings/@elastic/eui/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ declare module '@elastic/eui' {
export const EuiDescribedFormGroup: React.SFC<any>;
export const EuiCodeEditor: React.SFC<any>;
export const Query: any;
export const EuiCard: any;
}

declare module '@elastic/eui/lib/services' {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1019,10 +1019,10 @@
tabbable "^1.1.0"
uuid "^3.1.0"

"@elastic/eui@14.3.0":
version "14.3.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-14.3.0.tgz#256e1af8f6b15717904f8959742a23b3495ff0bb"
integrity sha512-gAbPNezBmndInYqqw6EvRYLn2VMYQgYuPQYA5UZ7TyHzwvoBiMpUw5nFzYhS2A/Xcmq/ON5Mu8RY3LGRAVBOvQ==
"@elastic/eui@14.4.0":
version "14.4.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-14.4.0.tgz#ac09a476798dcdb1005616cccc149eda23ea2a90"
integrity sha512-dR7lYwUaIRXZjlUrJBq8GcGLPh6QfM3waQxUFI8lOnMVayJe3OOMNADCn8Oty6wNYIOrBWzZbW6w4bzInWF6oA==
dependencies:
"@types/lodash" "^4.14.116"
"@types/numeral" "^0.0.25"
Expand Down