[Maps] retrieve geo_point value from docvalue_fields instead of _source #47389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
thomasneirynck
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
tested in chrome and works. nice to get some complexity removed from this.
remove
- https://github.com/elastic/kibana/blob/c2dff771f86fd971a1d1262e69fddc43baca5f4b/x-pack/plugins/translations/translations/ja-JP.json#L5760
- https://github.com/elastic/kibana/blob/c2dff771f86fd971a1d1262e69fddc43baca5f4b/x-pack/plugins/translations/translations/zh-CN.json#L5762
to get i18n working
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 11, 2019
…ce (elastic#47389) * [Maps] retrieve geo_point value from docvalue_fields instead of _source * add functional test ensuring _search request only pulls what is needed * clean up i18n translation fiels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #45270
This PR updates the Elasticsearch search request to request geo_point geometry from docvalue_fields instead of _source. This way, docvalue_fields will come back in a
lat,lonstring format regardless of how the field is stored in _source.Run the following in console to load a test data set with WKT to test the PR out.