Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Add Mappings Editor to Index Template Wizard #47562

Merged
merged 111 commits into from Jan 15, 2020

Conversation

@jloleysens
Copy link
Contributor

jloleysens commented Oct 8, 2019

Summary

Introduction of the new Mappings Editor component in the Index Management App. This PR is the central feature branch where all proposed changes can be viewed.

Mappings Editor Component

Create a reusable component to edit the mappings of an index. This component will be used in several CRUD UIs (create index, reindex index, create index template, edit index template...).
As such, the component responsibility will be to create the mappings object and forward it to the parent component.

Checklist

  • Integrate inside template UI (#47567)
  • Add Json editor for field settings in flyout (#47674)
  • Add UI from mockups (#48876)
  • All forms for all field types
  • Final x-browser tests (IE11, Safari etc)
  • Add copy + i18n
  • A11y tests

Screenshots

image

image

sebelga added 4 commits Oct 8, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 8, 2019

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 8, 2019

sebelga added 2 commits Oct 8, 2019
@sebelga sebelga added the v8.0.0 label Oct 8, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 8, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 10, 2019

@sebelga sebelga added v7.6.0 and removed v7.5.0 labels Oct 15, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 15, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 22, 2019

@sebelga sebelga mentioned this pull request Oct 22, 2019
@sebelga

This comment has been minimized.

Copy link
Contributor

sebelga commented Jan 14, 2020

@fbaligand Very interesting! Unfortunately, the mappings editor does not expose a JSON schema, but we are having discussions with the team to see how the ES API could expose them. As it would require a high level of work I can't tell you if or when those might land.

…ppings (#54532)
@fbaligand

This comment has been minimized.

Copy link
Contributor

fbaligand commented Jan 14, 2020

@sebelga
Nice to see you find it very interesting ;)
And why not, elasticsearch team could use my json schema as a start for their json schema ;)
For info, I don’t spend a lot of time to create it, I would say 2-3 days. I used some tools to generate index settings with their default values, which saved me a lot of time. (/my-index/_settings?include_defaults&flat_settings + online json schema generator from a json + regexp replacement)

sebelga added 2 commits Jan 14, 2020
@sebelga

This comment has been minimized.

Copy link
Contributor

sebelga commented Jan 14, 2020

@elasticmachine merge upstream

elasticmachine and others added 3 commits Jan 14, 2020
@cjcenizal

This comment has been minimized.

Copy link
Contributor

cjcenizal commented Jan 14, 2020

@elasticmachine merge upstream

elasticmachine and others added 5 commits Jan 14, 2020
@cjcenizal

This comment has been minimized.

Copy link
Contributor

cjcenizal commented Jan 14, 2020

Failure looks like something unrelated in ciGroup4:

hudson.AbortException: script returned exit code 1
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.handleExit(DurableTaskStep.java:658)
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.check(DurableTaskStep.java:604)
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.run(DurableTaskStep.java:548)
cjcenizal added 2 commits Jan 14, 2020
…or, rank_feature and rank_features. (#54841)
@cjcenizal

This comment has been minimized.

Copy link
Contributor

cjcenizal commented Jan 15, 2020

Same as before, but in ciGroup10.

@cjcenizal

This comment has been minimized.

Copy link
Contributor

cjcenizal commented Jan 15, 2020

🎉

@cjcenizal cjcenizal merged commit dfce824 into master Jan 15, 2020
55 checks passed
55 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Example functional tests node scripts/functional_tests --config test/examples/config.js --bail --debug
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.ts --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-2
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Kibana accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --config test/accessibility/config.ts
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-2 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-11 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-3 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-4 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-5 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-6 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-7 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-8 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-9 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-10 --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Karma Tests yarn test:browser
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana --config test/accessibility/config.ts
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-1 --include-tag smoke --config test/functional/config.firefox.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@cjcenizal cjcenizal changed the title [Index Management] Mappings Editor + Template UI update [Index Management] Add Mappings Editor to Index Template Wizard Jan 15, 2020
@cjcenizal cjcenizal deleted the feature/mappings-editor branch Jan 15, 2020
@kibanamachine

This comment has been minimized.

Copy link

kibanamachine commented Jan 15, 2020

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal added a commit that referenced this pull request Jan 15, 2020
…#47562) (#54864)

* Skip flakey index template component integration tests.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 15, 2020
* upstream/master: (72 commits)
  [ML] Calculate model memory limit API integration tests (elastic#54557)
  Skip flakey index template component integration tests. (elastic#54878)
  Add label and icon to nested fields in the doc table (elastic#54199)
  Reverse dependency of home plugin and apm/ml/cloud (elastic#52883)
  [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
  update invalid snapshot
  add readme note about alerting / manage_api_key cluster privilege (elastic#54639)
  [SIEM] New Overview Page (elastic#54783)
  [Uptime] Feature/refactor context initialization (elastic#54494)
  Upgrade EUI to v18.2.0 (elastic#54786)
  [SIEM] [Detection engine] from signals to timeline (elastic#54769)
  [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562)
  [SIEM][Detection Engine] Removes deprecated filter from mapping
  [Maps] Add categorical styling (elastic#54408)
  Add mapbox-gl-rtl-text library (elastic#54842)
  [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828)
  Lexicographically sort location tags (elastic#54832)
  [Maps] expand extent filter to tile boundaries (elastic#54276)
  [Maps] Use v7.6 Elastic Maps Service API (elastic#54399)
  [DOCS] Adds monitoring setting (elastic#54819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.