Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Add Mappings Editor to Index Template Wizard #47562

Merged
merged 111 commits into from
Jan 15, 2020

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Oct 8, 2019

Release note

We've added a visual editor the Index Template mappings which lets you add, remove, edit, and collapse and expand fields. Each field data type is documented in the user interface to make it easy to configure your mappings. If you're working with JSON, you can load it into the editor with the "Load JSON" button. If your mappings are complex and deeply nested you can search them to quickly find the field you want.

image

image

image

Summary

Introduction of the new Mappings Editor component in the Index Management App. This PR is the central feature branch where all proposed changes can be viewed.

Mappings Editor Component

Create a reusable component to edit the mappings of an index. This component will be used in several CRUD UIs (create index, reindex index, create index template, edit index template...).
As such, the component responsibility will be to create the mappings object and forward it to the parent component.

Checklist

Screenshots

image

image

@jloleysens jloleysens added release_note:enhancement Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.5.0 labels Oct 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sebelga sebelga added the v8.0.0 label Oct 8, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sebelga sebelga added v7.6.0 and removed v7.5.0 labels Oct 15, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sebelga sebelga mentioned this pull request Oct 22, 2019
@sebelga
Copy link
Contributor

sebelga commented Jan 14, 2020

@fbaligand Very interesting! Unfortunately, the mappings editor does not expose a JSON schema, but we are having discussions with the team to see how the ES API could expose them. As it would require a high level of work I can't tell you if or when those might land.

@fbaligand
Copy link
Contributor

@sebelga
Nice to see you find it very interesting ;)
And why not, elasticsearch team could use my json schema as a start for their json schema ;)
For info, I don’t spend a lot of time to create it, I would say 2-3 days. I used some tools to generate index settings with their default values, which saved me a lot of time. (/my-index/_settings?include_defaults&flat_settings + online json schema generator from a json + regexp replacement)

@sebelga
Copy link
Contributor

sebelga commented Jan 14, 2020

@elasticmachine merge upstream

@cjcenizal
Copy link
Contributor

@elasticmachine merge upstream

@cjcenizal
Copy link
Contributor

Failure looks like something unrelated in ciGroup4:

hudson.AbortException: script returned exit code 1
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.handleExit(DurableTaskStep.java:658)
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.check(DurableTaskStep.java:604)
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.run(DurableTaskStep.java:548)

@cjcenizal
Copy link
Contributor

Same as before, but in ciGroup10.

@cjcenizal
Copy link
Contributor

🎉

@cjcenizal cjcenizal merged commit dfce824 into master Jan 15, 2020
@cjcenizal cjcenizal changed the title [Index Management] Mappings Editor + Template UI update [Index Management] Add Mappings Editor to Index Template Wizard Jan 15, 2020
@cjcenizal cjcenizal deleted the feature/mappings-editor branch January 15, 2020 01:10
@kibanamachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal added a commit that referenced this pull request Jan 15, 2020
…#47562) (#54864)

* Skip flakey index template component integration tests.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 15, 2020
* upstream/master: (72 commits)
  [ML] Calculate model memory limit API integration tests (elastic#54557)
  Skip flakey index template component integration tests. (elastic#54878)
  Add label and icon to nested fields in the doc table (elastic#54199)
  Reverse dependency of home plugin and apm/ml/cloud (elastic#52883)
  [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
  update invalid snapshot
  add readme note about alerting / manage_api_key cluster privilege (elastic#54639)
  [SIEM] New Overview Page (elastic#54783)
  [Uptime] Feature/refactor context initialization (elastic#54494)
  Upgrade EUI to v18.2.0 (elastic#54786)
  [SIEM] [Detection engine] from signals to timeline (elastic#54769)
  [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562)
  [SIEM][Detection Engine] Removes deprecated filter from mapping
  [Maps] Add categorical styling (elastic#54408)
  Add mapbox-gl-rtl-text library (elastic#54842)
  [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828)
  Lexicographically sort location tags (elastic#54832)
  [Maps] expand extent filter to tile boundaries (elastic#54276)
  [Maps] Use v7.6 Elastic Maps Service API (elastic#54399)
  [DOCS] Adds monitoring setting (elastic#54819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Index Management Index and index templates UI Feature:Mappings Editor Index mappings editor UI release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants