Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group auth-related config items together #4844

Merged
merged 4 commits into from
Sep 14, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 2, 2015

Moved from #4699

@spalger
Copy link
Contributor Author

spalger commented Sep 2, 2015

@tbragin I added the logging options to the config file in spalger@e5dfa42 but I think they might a bit overkill and just cluttering the config file. @rashidkpc thoughts?

@@ -25,7 +25,11 @@
# elasticsearch.username: user
# elasticsearch.password: pass

# If your Elasticsearch requires client certificate and key
# SSL for outgoing requests from the Kibana Server to the browser (PEM formatted)
# server.ssl.cert: /path/to/your/server.crt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSL for Kibana's built in webserver. These settings secure communication between user's browser and the kibana server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rashidkpc
Copy link
Contributor

I agree, I' m not sure we need those log settings. They look like clutter.

rashidkpc added a commit that referenced this pull request Sep 14, 2015
Group auth-related config items together
@rashidkpc rashidkpc merged commit 47cca84 into elastic:master Sep 14, 2015
@spalger spalger deleted the fix/configFileOrder branch February 25, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants