[Uptime] Revert router base name for Uptime plugin #50095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
7 tasks
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Nov 12, 2019
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Nov 12, 2019
justinkambic
added a commit
that referenced
this pull request
Nov 12, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
justinkambic
added a commit
that referenced
this pull request
Nov 12, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
…skip ci] * upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Nov 13, 2019
…ult path. (elastic#50095) (elastic#50239)" This reverts commit ddeee7e.
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #49391.
In #46269 we removed the hash value from our default router base name. We did this because we thought it wasn't needed. This patch reverts that change, because it had unforeseen impacts on our routing and breadcrumb generation.
Testing