-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Improve UI tests and platform #46269
Conversation
Pinging @elastic/uptime |
💔 Build Failed |
@elasticmachine merge upstream |
💔 Build Failed |
@spalger I'm not fully understanding the error messages I'm seeing but it seems like most of the tests aren't running. |
💔 Build Failed |
@elasticmachine merge upstream |
💚 Build Succeeded40 successful executions |
@elasticmachine merge upstream |
💔 Build Failed40 successful executions, flaky failure #43736 |
@elasticmachine merge upstream |
💚 Build Succeeded40 successful executions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
120 successful runs, LGTM!
💚 Build Succeeded |
* Remove depdency on legacy interface. * Remove custom interface, use common breadcrumb type. * Add HTML template for app react entry point. * Update app props. * Add constant for react app entry point. * Remove dependency on legacy capabilities provider. * Delete legacy kibana framework adapter. * Add New Platform adapter, reference in startup code. * Remove dependency on legacy capabilities function. * Delete reference to obsolete interface. * Fix busted types in new adapter. * Add new plugin class, delete old bootstrap code. * Update routing/functional tests. * Provide default for potentially-undefined value. * run x-pack-ciGroup6 40 times * Reinsert firefox skip tag. * Update functional tests to work with newly-merged fixtures. * Revert "run x-pack-ciGroup6 40 times" This reverts commit ac3b1e4.
* Remove depdency on legacy interface. * Remove custom interface, use common breadcrumb type. * Add HTML template for app react entry point. * Update app props. * Add constant for react app entry point. * Remove dependency on legacy capabilities provider. * Delete legacy kibana framework adapter. * Add New Platform adapter, reference in startup code. * Remove dependency on legacy capabilities function. * Delete reference to obsolete interface. * Fix busted types in new adapter. * Add new plugin class, delete old bootstrap code. * Update routing/functional tests. * Provide default for potentially-undefined value. * run x-pack-ciGroup6 40 times * Reinsert firefox skip tag. * Update functional tests to work with newly-merged fixtures. * Revert "run x-pack-ciGroup6 40 times" This reverts commit ac3b1e4.
Summary
Do not review before #44722 is merged.Resolves #46245.
For some time now Uptime's UI tests have not been running because of routing difficulties and flaky behavior. This patch seeks to update the way the app routes and re-enable several tests that have been skipped until now.
The success criteria for this change is that it will be easy for us to add additional functional tests in the future as we introduce new features.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers