[Uptime] Hide integration using IP when IP not present #50138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic#49366 , where this issue was first described. If linking is based on IP we should only show the link if we actually have an IP.
andrewvc
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
andrewvc
commented
Nov 11, 2019
x-pack/legacy/plugins/uptime/public/lib/helper/observability_integration/get_logging_href.ts
Show resolved
Hide resolved
💚 Build Succeeded |
justinkambic
approved these changes
Nov 12, 2019
|
@justinkambic can I get one more quick review? I realize that one final commit with extra tests didn't make it in. |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Nov 14, 2019
Fixes elastic#49366 , where this issue was first described. If linking is based on IP we should only show the link if we actually have an IP.
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Nov 14, 2019
Fixes elastic#49366 , where this issue was first described. If linking is based on IP we should only show the link if we actually have an IP.
andrewvc
added a commit
that referenced
this pull request
Dec 10, 2019
andrewvc
added a commit
that referenced
this pull request
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49366 , where this issue was first described. If linking is based on IP we should only show the link if we actually have an IP.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers