NP Migration: Sample data #52753
Merged
NP Migration: Sample data #52753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver_tutorials_api
…orm tutorial plugin registrations
… tutorials service
… the home plugin public folder
…gin_home_feature_catalogue
…s api http routes for legacy platform and NP
flash1293
added
release_note:skip
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Kerry350
approved these changes
Dec 12, 2019
kertal
approved these changes
Dec 19, 2019
|
|
||
| // Set to true to move timestamp to current week, preserving day of week and time of day | ||
| // Relative distance from timestamp to currentTimeMarker will not remain the same | ||
| preserveDayOfWeekTimeOfDay: boolean; |
There was a problem hiding this comment.
This goes to @TinaHeiligers - I just brought the PR home :)
| logger: Logger | ||
| ) => { | ||
| const bulkInsert = async (docs: any) => { | ||
| function updateTimestamps(doc: any) { |
There was a problem hiding this comment.
Minor nit: it would help code readability at this position to e.g. refactor updateTimestamps out of the bulkInsert function, and to use an arrow function. would de-nest the code.
There was a problem hiding this comment.
Good point, refactored this a bit.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
crob611
approved these changes
Dec 20, 2019
kindsun
approved these changes
Dec 20, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Dec 20, 2019
flash1293
added a commit
that referenced
this pull request
Dec 20, 2019
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50675
This PR migrates all APIs and route handlers around sample data to the new platform as part of the
home plugin.Changes the status code of the uninstall route from
200to204