Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP Migration: Sample data #52753

Merged
merged 97 commits into from Dec 20, 2019
Merged
Show file tree
Hide file tree
Changes from 95 commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
6faa981
[NP:Kibana:homeAPI] initializes a new plugin (WIP)
TinaHeiligers Nov 12, 2019
a24e7f2
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_ser…
TinaHeiligers Nov 12, 2019
eeeaae6
Typing
TinaHeiligers Nov 12, 2019
7a78b55
New plugin tutorials not needing server working
TinaHeiligers Nov 12, 2019
dfa5e34
Retains legacy tutorial registration and adds new route for new platf…
TinaHeiligers Nov 12, 2019
31548ef
Adds comment on where to pre-register general non-plugin specific tut…
TinaHeiligers Nov 13, 2019
560e7d2
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 13, 2019
c22d787
Converts TutorialsPlugin to TutorialsRegistry service in new Home plugin
TinaHeiligers Nov 13, 2019
1741e3c
Changes call to location of registerTutorial in registerTutorials
TinaHeiligers Nov 13, 2019
aca40b9
Adds console log for the home plugin that's returning an empty object
TinaHeiligers Nov 13, 2019
10d477a
Removes async from setup and start methods in the home plugin and the…
TinaHeiligers Nov 13, 2019
de06bc0
Starts writing tests and creating mocks
TinaHeiligers Nov 14, 2019
7a7ce9a
Adds basic tests for TutorialRegistry service
TinaHeiligers Nov 14, 2019
fcedb41
Adds basic tests for TutorialRegistry service
TinaHeiligers Nov 14, 2019
a77aced
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 14, 2019
1862438
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 14, 2019
628e410
Adds test for route
TinaHeiligers Nov 14, 2019
cc978bd
Adds mocks and tests for the home plugin
TinaHeiligers Nov 14, 2019
6607a40
Adds home plugin to security plugin and registers scoped tutorials se…
TinaHeiligers Nov 15, 2019
a4fba59
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 15, 2019
8e6177f
Removes incorrect addition to src core server
TinaHeiligers Nov 15, 2019
14d3068
Fixes type errors
TinaHeiligers Nov 15, 2019
16a0a38
Deletes unused code
TinaHeiligers Nov 15, 2019
4f9399f
[Kibana NP migration] begins moving the feature_catalogue plugin into…
TinaHeiligers Nov 15, 2019
02176a4
Fixes feature_catalogue imports
TinaHeiligers Nov 15, 2019
93d67d6
Deletes duplicate golangMetricsSpecProvider registration
TinaHeiligers Nov 15, 2019
f493a7e
Deletes feature_catalogue plugin
TinaHeiligers Nov 16, 2019
1d79358
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 16, 2019
100380e
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 16, 2019
8d49809
Nests tutorials service in a tutorials key in the home plugin, change…
TinaHeiligers Nov 16, 2019
4bdbaf2
Merge branch 'NP_kibana_plugin_home' into NP_kibana_plugin_home_featu…
TinaHeiligers Nov 16, 2019
e40089d
Nests featureCatalogue methods into an object within the HomePublicPl…
TinaHeiligers Nov 16, 2019
7f553fb
Changes url variable names
TinaHeiligers Nov 17, 2019
043af9a
Merge branch 'NP_kibana_plugin_home' into NP_kibana_plugin_home_featu…
TinaHeiligers Nov 17, 2019
cb1a9f3
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 17, 2019
6dc0205
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 17, 2019
d5a120e
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 18, 2019
cbb950c
Merge branch 'NP_kibana_plugin_home' into NP_kibana_plugin_home_featu…
TinaHeiligers Nov 18, 2019
9a0f060
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 18, 2019
68159e5
Changes HomePlugin to HomePluginServer
TinaHeiligers Nov 18, 2019
a485ba2
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 19, 2019
2fad345
Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…
TinaHeiligers Nov 19, 2019
83a43bf
Update src/core/MIGRATION.md
TinaHeiligers Nov 19, 2019
e0faa71
Moves feature_catalogue services into a subfolder
TinaHeiligers Nov 19, 2019
9a73942
Moves tutorials-related service files into a subfolder in the server …
TinaHeiligers Nov 19, 2019
69208d8
Merge branch 'NP_kibana_plugin_home_feature_catalogue' into NP_migrat…
TinaHeiligers Nov 19, 2019
ca6c7a2
[NP migration] begins migration of sample data into the home plugin
TinaHeiligers Nov 19, 2019
3e5921e
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 19, 2019
b702ad6
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 20, 2019
1d0b61a
Adds methods to the setup phase of the sample data Registry service
TinaHeiligers Nov 20, 2019
0a1cc39
Copies over sample datasets from src/legacy/server/sample_data/data_s…
TinaHeiligers Nov 20, 2019
a9b6ae1
comments out WIP route for lising the sample data
TinaHeiligers Nov 21, 2019
8de9fbe
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 21, 2019
7349427
Starts adding the get route to the sample data service
TinaHeiligers Nov 21, 2019
c6c99eb
Completes createListRoute and moves it to a new file in a routes folder
TinaHeiligers Nov 21, 2019
098f742
Fixes types excluding unused initContext
TinaHeiligers Nov 21, 2019
d5e602c
Migrates install route to the sample data service within the home plugin
TinaHeiligers Nov 21, 2019
a417e91
Fixes some linting errors
TinaHeiligers Nov 22, 2019
9675bc9
typing
TinaHeiligers Nov 22, 2019
007a5ac
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 22, 2019
c25ff5b
Changes zlib.Unzip to createUnzip
TinaHeiligers Nov 22, 2019
3427305
Correctly validates request on install route
TinaHeiligers Nov 22, 2019
409ed2e
Wires up install route but there's still an issue with a missing dash…
TinaHeiligers Nov 22, 2019
72dcb23
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 22, 2019
5ffc848
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 24, 2019
3aea8bb
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 25, 2019
79c22c1
Uses NP sampleData methods in Canvas shim
TinaHeiligers Nov 25, 2019
dda4343
[NP-migration] refactors Canvas server sampleData savedObjects additi…
TinaHeiligers Nov 25, 2019
5b436d5
Adds @ts-ignore and TODO's to resolve type issues
TinaHeiligers Nov 25, 2019
b3ca316
Destructures arguments provided to replacePanelInSampleDatasetDashboard
TinaHeiligers Nov 25, 2019
38404c9
Adds EmbeddableConfig interface
TinaHeiligers Nov 25, 2019
7c9a271
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 25, 2019
7d6c09c
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 25, 2019
209d488
[WIP] still debugging Flights and Ecommerce dashboard Controls and Ma…
TinaHeiligers Nov 25, 2019
411aa15
Merge branch 'NP_migration_add_sample_datasets_to_maps_and_canvas' in…
TinaHeiligers Nov 26, 2019
12d29c4
_Np migration sample data install api (#12)
TinaHeiligers Nov 26, 2019
6405659
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 26, 2019
795cc51
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 27, 2019
73c268f
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Nov 29, 2019
e64338e
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Dec 1, 2019
07b4a79
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Dec 2, 2019
c63d4dc
Merge branch 'master' of github.com:elastic/kibana into NP_migration_…
TinaHeiligers Dec 3, 2019
9cd9f22
Merge remote-tracking branch 'upstream/master' into NP_migration_samp…
flash1293 Dec 6, 2019
f062d29
move over rest of sample data plugin
flash1293 Dec 6, 2019
1e5b6a4
Merge remote-tracking branch 'upstream/master' into NP_migration_samp…
flash1293 Dec 9, 2019
f481bee
Merge remote-tracking branch 'upstream/master' into NP_migration_samp…
flash1293 Dec 10, 2019
b26cb8f
fix typing issues and remove lodash reference
flash1293 Dec 10, 2019
e2b9cea
Merge remote-tracking branch 'upstream/master' into NP_migration_samp…
flash1293 Dec 10, 2019
bb6276c
fix i18n
flash1293 Dec 10, 2019
a0432cc
fix todos
flash1293 Dec 10, 2019
89b9fde
Merge remote-tracking branch 'upstream/master' into NP_migration_samp…
flash1293 Dec 11, 2019
41922b6
move prototype pollution test to new api
flash1293 Dec 11, 2019
4204cbf
adjust integration test
flash1293 Dec 11, 2019
a421c66
Merge remote-tracking branch 'upstream/master' into migration/sample-…
flash1293 Dec 16, 2019
1766d49
Merge remote-tracking branch 'upstream/master' into migration/sample-…
flash1293 Dec 18, 2019
63c682e
Merge remote-tracking branch 'upstream/master' into migration/sample-…
flash1293 Dec 20, 2019
0775649
improve readability
flash1293 Dec 20, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .i18nrc.json
Expand Up @@ -11,6 +11,7 @@
"embeddableApi": "src/plugins/embeddable",
"embeddableExamples": "examples/embeddable_examples",
"share": "src/plugins/share",
"home": "src/plugins/home",
"esUi": "src/plugins/es_ui_shared",
"devTools": "src/plugins/dev_tools",
"expressions": "src/plugins/expressions",
Expand Down
2 changes: 2 additions & 0 deletions src/legacy/server/kbn_server.d.ts
Expand Up @@ -44,6 +44,7 @@ import { UsageCollectionSetup } from '../../plugins/usage_collection/server';
import { IndexPatternsServiceFactory } from './index_patterns';
import { Capabilities } from '../../core/server';
import { UiSettingsServiceFactoryOptions } from '../../legacy/ui/ui_settings/ui_settings_service_factory';
import { HomeServerPluginSetup } from '../../plugins/home/server';

// lot of legacy code was assuming this type only had these two methods
export type KibanaConfig = Pick<LegacyConfig, 'get' | 'has'>;
Expand Down Expand Up @@ -99,6 +100,7 @@ type KbnMixinFunc = (kbnServer: KbnServer, server: Server, config: any) => Promi

export interface PluginsSetup {
usageCollection: UsageCollectionSetup;
home: HomeServerPluginSetup;
[key: string]: object;
}

Expand Down
4 changes: 0 additions & 4 deletions src/legacy/server/kbn_server.js
Expand Up @@ -35,7 +35,6 @@ import optimizeMixin from '../../optimize';
import * as Plugins from './plugins';
import { indexPatternsMixin } from './index_patterns';
import { savedObjectsMixin } from './saved_objects/saved_objects_mixin';
import { sampleDataMixin } from './sample_data';
import { capabilitiesMixin } from './capabilities';
import { urlShorteningMixin } from './url_shortening';
import { serverExtensionsMixin } from './server_extensions';
Expand Down Expand Up @@ -112,9 +111,6 @@ export default class KbnServer {
// setup capabilities routes
capabilitiesMixin,

// setup routes for installing/uninstalling sample data sets
sampleDataMixin,

// setup routes for short urls
urlShorteningMixin,

Expand Down
20 changes: 0 additions & 20 deletions src/legacy/server/sample_data/README.md

This file was deleted.

184 changes: 0 additions & 184 deletions src/legacy/server/sample_data/routes/install.js

This file was deleted.

30 changes: 0 additions & 30 deletions src/legacy/server/sample_data/routes/lib/create_index_name.test.js

This file was deleted.

59 changes: 0 additions & 59 deletions src/legacy/server/sample_data/routes/lib/load_data.test.js

This file was deleted.