[Search service] Add async search strategy #53057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
5 tasks
This was referenced Jan 17, 2020
|
we're past 7.6.0 FF, can you please bump label to v7.7.0 |
|
@elasticmachine merge upstream |
lizozom
approved these changes
Feb 25, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Feb 25, 2020
* Add async search strategy * Add async search * Fix async strategy and add tests * Move types to separate file * Revert changes to demo search * Update demo search strategy to use async * Add cancellation to search strategies * Add tests * Simplify async search strategy * Move loadingCount to search strategy * Update abort controller library * Bootstrap * Abort when the request is aborted * Add utility and update value suggestions route * Fix bad merge conflict * Update tests * Move to data_enhanced plugin * Remove bad merge * Revert switching abort controller libraries * Revert package.json in lib * Move to previous abort controller * Fix test to use fake timers to run debounced handlers * Revert changes to example plugin * Fix loading bar not going away when cancelling * Call getSearchStrategy instead of passing directly * Add async demo search strategy * Fix error with setting state * Update how aborting works * Fix type checks * Add test for loading count * Attempt to fix broken example test * Revert changes to test * Fix test * Update name to camelCase * Fix failing test * Don't require data_enhanced in example plugin Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
7.x (7.7.0): b0336a7 |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #48811.
This PR adds a new abstract asynchronous search strategy (as opposed to the existing synchronous search strategy). It sends the first request as given (with all request parameters), and expects to receive an
idin the response, which it then uses to poll the same backend endpoint until the response indicates that it is complete by sending aloadedproperty that is equal to thetotalproperty.The location of this new search strategy is inside a new enhanced data plugin (
data_enhanced) which is meant to contain the basic & commercial features related to the OSS data plugin (data).At the moment, no existing search strategies are using this, but when the asynchronous search APIs land in Elasticsearch, we will override the existing
ES_SEARCH_STRATEGYto use this async strategy to make the initial request and then poll.This PR also removes the
percentCompleteoptional property inIKibanaSearchResponse, as it can easily be derived fromtotal / loadedin the response (if provided).Remaining to do
signalis abortedChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers