Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working #53799

Merged
merged 3 commits into from
Dec 30, 2019
Merged

[Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working #53799

merged 3 commits into from
Dec 30, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 26, 2019 •
edited
Loading

Closes: #53748

Summary

Vega Visualization does not show the map if Kibana is running under the oss license or Map visualization is disabled.

To display the map in Vega visualization, the emsTileLayerId configuration property must be entered and accessible. Currently we do it only from one place: seex-pack/legacy/plugins/maps/index.js. This means that if for some reason the Maps plugin is not initialized, we cannot use the map view also on the Vega plugin.

Screenshot:

image

Regression after shimming the Vega/ Maps plugin

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Dec 26, 2019
@alexwizp alexwizp added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp
Copy link
Contributor Author

PR was updated: the same fix was applied to Tile Map / Coordinate Map visualizations

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review December 26, 2019 18:34
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

streamich
streamich approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit e7ee646 into elastic:master Dec 30, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Dec 30, 2019
@alexwizp @elasticmachine
[Vega] Sample [Flights] Airport Connections (Hover Over Airport) visu…
ecbd054 
…alization not working (elastic#53799)

Closes: elastic#53748

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Dec 30, 2019
Merged
alexwizp added a commit that referenced this pull request Jan 1, 2020
@alexwizp @elasticmachine
[Vega] Sample [Flights] Airport Connections (Hover Over Airport) visu…
4cbc5b7 
…alization not working (#53799) (#53857)

Closes: #53748

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into alerting/zombie-tasks
6223180 
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into alerting/created_at-and-updated_at
fe1902e 
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into alerting/client-types
fa3e74f 
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into task-manager/schema-config
4246b94 
* master:
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
@alexwizp @elasticmachine @jkelastic
[Vega] Sample [Flights] Airport Connections (Hover Over Airport) visu…
b966c21 
…alization not working (elastic#53799)

Closes: elastic#53748

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

@timroes timroes Awaiting requested review from timroes

@lizozom lizozom Awaiting requested review from lizozom

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees

@alexwizp alexwizp

Labels
Feature:NP Migration Feature:Vega Vega visualizations regression release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working
4 participants
@alexwizp @elasticmachine @kibanamachine @streamich