[Telemetry] fix bug where uiStatsMetrics is not getting reported

[Bamieh]

Summary

On kibana 7.6 and 8.0 UI metrics currently does not report the uiStatsMetrics part of the ui metrics report. This is happening due to wrapping the code in an if statement that always resolves to false.

Our test cases dont catch this since we mimic the report object instead of generating it directly from reportManager.assignReports as we do in production.

This PR fixes the bug and the tests to catch any similar cases in the future.

Reference: #52893

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: fe01c92

History

• 💚 Build #18172 succeeded 4cc4001

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[TinaHeiligers]

I reviewed the code and ran this locally with and without the fix.
With this PR, we get the uiStatsMetrics reported and I was able to log out the contents:

In route handler for reporting ui_metrics, report.uiStatsMetrics { 'Kibana_home-loaded-welcomeScreenMount':
   { key: 'Kibana_home-loaded-welcomeScreenMount',
     appName: 'Kibana_home',
     eventName: 'welcomeScreenMount',
     type: 'loaded',
     stats: { min: 0, max: 1, avg: 0.5, sum: 1 } },
  'Kibana_home-click-sampleDataConfirm':
   { key: 'Kibana_home-click-sampleDataConfirm',
     appName: 'Kibana_home',
     eventName: 'sampleDataConfirm',
     type: 'click',
     stats: { min: 0, max: 1, avg: 0.5, sum: 1 } },
  'visualize-click-lens':
   { key: 'visualize-click-lens',
     appName: 'visualize',
     eventName: 'lens',
     type: 'click',
     stats: { min: 0, max: 1, avg: 0.5, sum: 1 } } }
--> report.uiStatsMetrics { 'Kibana_home-loaded-welcomeScreenMount':
   { key: 'Kibana_home-loaded-welcomeScreenMount',
     appName: 'Kibana_home',
     eventName: 'welcomeScreenMount',
     type: 'loaded',
     stats: { min: 0, max: 1, avg: 0.5, sum: 1 } },
  'Kibana_home-click-sampleDataConfirm':
   { key: 'Kibana_home-click-sampleDataConfirm',
     appName: 'Kibana_home',
     eventName: 'sampleDataConfirm',
     type: 'click',
     stats: { min: 0, max: 1, avg: 0.5, sum: 1 } },
  'visualize-click-lens':
   { key: 'visualize-click-lens',
     appName: 'visualize',
     eventName: 'lens',
     type: 'click',
     stats: { min: 0, max: 1, avg: 0.5, sum: 1 } } }

Without the fix (or without running yarn-kbn-bootstrap, report.uiStatsMetrics is undefined

We also see uiStatsMetrics in the payload: