[Data Table] Formatting CSV properly #54127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
added
Feature:Data Table
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Checked locally on Chrome, LGTM! 👌 |
mbondyra
approved these changes
Jan 10, 2020
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 12, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jan 13, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
majagrubic
pushed a commit
that referenced
this pull request
Jan 13, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #53795
The problem was that when checking for formatted cells,
split columnswere never checked. This PR fixes that.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers