New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Fix flaky snapshot count test by adding timeout for required element #54839

Closed

justinkambic wants to merge 8 commits into elastic:master from justinkambic:uptime_fix-flaky-test-snapshot-count

Contributor

justinkambic commented Jan 14, 2020

Summary

Fixes #54527.

This test was failing periodically because we were applying filters to our application state and expecting the data displayed to be present. At times this takes longer to render than what we were seeing in our local environments. This PR adds a retry block to those tests in an effort to ensure that the page has adequate time to re-render with the updated data.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

justinkambic added blocker failed-test v8.0.0 Team:Uptime - DEPRECATED skipped-test release_note:skip v7.6.0 labels

justinkambic self-assigned this

Contributor

elasticmachine commented Jan 14, 2020

Pinging @elastic/kibana-test-triage (failed-test)

Contributor

elasticmachine commented Jan 14, 2020

Pinging @elastic/uptime (Team:uptime)

justinkambic requested a review from andrewvc

January 14, 2020 22:35

andrewvc approved these changes

View reviewed changes

Contributor

andrewvc left a comment

LGTM WFG. Let's run this a second time after it goes green just in case. No rush here.

Contributor Author

justinkambic commented Jan 15, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Jan 15, 2020

user doesn't have permission to update head repository

Contributor Author

justinkambic commented Jan 15, 2020

Looks like we got a failure from an unrelated test.

Contributor Author

justinkambic commented Jan 15, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Jan 15, 2020

user doesn't have permission to update head repository

Contributor Author

justinkambic commented Jan 15, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Jan 15, 2020

user doesn't have permission to update head repository

justinkambic force-pushed the uptime_fix-flaky-test-snapshot-count branch from 048c04c to fabf96d Compare

January 15, 2020 12:55

Contributor Author

justinkambic commented Jan 15, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Jan 15, 2020

user doesn't have permission to update head repository

Contributor Author

justinkambic commented Jan 18, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Jan 18, 2020

user doesn't have permission to update head repository

Contributor Author

justinkambic commented Jan 18, 2020

@spalger is there a way I can get this PR to merge upstream so I don't have to manually merge master every time I want to re-run it?

Contributor Author

justinkambic commented Jan 21, 2020

@elasticmachine merge upstream

Contributor

elasticmachine commented Jan 21, 2020

user doesn't have permission to update head repository

justinkambic added 2 commits

January 21, 2020 08:33


          Add timeout to snapshot functional tests for required element.

d49d2ad


          Add retry handler to flaky functional tests that sometimes require mo…

17367c1

…re load time.

justinkambic force-pushed the uptime_fix-flaky-test-snapshot-count branch from fabf96d to 17367c1 Compare

January 21, 2020 13:33

justinkambic added 6 commits

January 21, 2020 09:32


          Merge branch 'master' into uptime_fix-flaky-test-snapshot-count

7ab4ec7


          Merge branch 'master' into uptime_fix-flaky-test-snapshot-count

24f5863


          Merge branch 'master' into uptime_fix-flaky-test-snapshot-count

82c4fa8


          Merge branch 'master' into uptime_fix-flaky-test-snapshot-count

8f909af


          Merge branch 'master' into uptime_fix-flaky-test-snapshot-count

b3a9519


          Merge branch 'master' into uptime_fix-flaky-test-snapshot-count

c248a3c

Contributor

kibanamachine commented Jan 28, 2020

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c248a3c

History

💔 Build #22828 failed b3a9519
💔 Build #22763 failed 8f909af
💔 Build #22391 failed 82c4fa8
💔 Build #22372 failed 24f5863
💔 Build #21554 failed 17367c1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Contributor Author

justinkambic commented Jan 30, 2020

#56065 fixed the test that this was aimed at solving.

justinkambic closed this

justinkambic deleted the uptime_fix-flaky-test-snapshot-count branch

January 30, 2020 21:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment