Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Data fetching twice on discover timefilter change #55279

Merged
merged 6 commits into from
Jan 21, 2020
Merged

[BUG] Data fetching twice on discover timefilter change #55279

merged 6 commits into from
Jan 21, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jan 19, 2020 •
edited
Loading

Summary

Fix bug #54887

  • Filters are not only fetch once on timefilter change
  • Make sure that discover doesn't fetch data when a disabled filter is changed
  • Support compareFilters on an array of filters.
  • Added tests to compare filters
  • Exctracted sortFilters and added tests to it.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Fix bug elastic#54887
f336038 
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.
@lizozom lizozom requested a review from a team January 19, 2020 12:30
@lizozom lizozom requested a review from a team as a code owner January 19, 2020 12:30
@lizozom lizozom self-assigned this Jan 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom changed the title [BUGFIX] Data fetching twice on discover timefilter change [BUG] Data fetching twice on discover timefilter change Jan 19, 2020
@lizozom
Copy link
Contributor Author

lizozom commented Jan 19, 2020

@elasticmachine merge upstream

Dosant
Dosant reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm and clicked a bit in dashboard,
left couple nit comments / questions.

src/legacy/core_plugins/data/public/filter/filter_manager/filter_state_manager.ts Show resolved Hide resolved
src/plugins/data/public/query/filter_manager/lib/compare_filters.ts Outdated Show resolved Hide resolved
src/plugins/data/public/query/filter_manager/lib/sort_filters.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested around and couldn't find a case where fetch is triggered multiple times - LGTM and thank you so much!

@lizozom lizozom merged commit 4ca2fbd into elastic:master Jan 21, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jan 21, 2020
@elasticmachine
[BUG] Data fetching twice on discover timefilter change (elastic#55279)
69edee7 
* Fix bug elastic#54887
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.

* code review + FilterCompareOptions

* Remove sort by

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lizozom lizozom mentioned this pull request Jan 21, 2020
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jan 21, 2020
@elasticmachine
[BUG] Data fetching twice on discover timefilter change (elastic#55279)
f0c089d 
* Fix bug elastic#54887
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.

* code review + FilterCompareOptions

* Remove sort by

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lizozom lizozom mentioned this pull request Jan 21, 2020
Merged
lizozom pushed a commit that referenced this pull request Jan 21, 2020
@elasticmachine
[BUG] Data fetching twice on discover timefilter change (#55279) (#55369
c33924f 
)

* Fix bug #54887
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.

* code review + FilterCompareOptions

* Remove sort by

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom pushed a commit that referenced this pull request Jan 21, 2020
@elasticmachine
[BUG] Data fetching twice on discover timefilter change (#55279) (#55368
3070f0b 
)

* Fix bug #54887
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.

* code review + FilterCompareOptions

* Remove sort by

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 21, 2020
@gmmorris
Merge branch 'master' into actions/platform
78e0253 
* master:
  [State Management] remove AppState from Dashboard app (elastic#54105)
  Expose fatalErrors API from the Start contract (elastic#55300)
  [BUG] Data fetching twice on discover timefilter change  (elastic#55279)
  [Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (elastic#55161)
  [Logs UI] Fix z-index of logs page toolbar (elastic#54469)
  removes CTA from Task Manager info message (elastic#55334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@Dosant Dosant Dosant approved these changes

Assignees

@lizozom lizozom

Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @kibanamachine @flash1293 @Dosant