[server/uiExports] allow apps to use export types that are empty #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an app "uses" an export type that the server has not received any registered modules for the server currently fails to start saying "Unable to find uiExports for pattern ...". While this error is valid it is not always desired, and I think it is simply too limiting. Apps need to be able to use exportTypes that are optional, so this change simply removes the error and treats the current method as an optional "uses".
|
Am I correct in understanding that |
|
Yessir, that's exactly the case |
|
In that case this LGTM |
spalger
added a commit
that referenced
this pull request
Dec 1, 2015
[server/uiExports] allow apps to use export types that are empty
MadameSheema
pushed a commit
to MadameSheema/kibana
that referenced
this pull request
Jan 31, 2023
Add tagging script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an app
uses:an export type that no plugin exports the server currently barfs up:While this error is valid it is not desired if we want to start adding more supported export types. This change simply removes the error and treats the current method as an optional
uses:.If it turns out that we need requires down the road we can always add it or apps could simply add the check in their own code and throw some sort of error if there are missing dependencies (which I prefer).