Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Retain pinned filters when loading and clearing saved queries (#54307) #55473

Merged
merged 1 commit into from
Jan 22, 2020
Merged

[7.x] Retain pinned filters when loading and clearing saved queries (#54307) #55473

merged 1 commit into from
Jan 22, 2020

Commits on Jan 21, 2020

  1. Retain pinned filters when loading and clearing saved queries (elasti… 

    …c#54307)

When we originally implemented Saved Queries we had them overwrite pinned filters on load and on clear. This caused the issue in elastic#53258. If you have a saved query loaded in Discover for example and you navigate to a different app and then back to Discover, that saved query will get get reloaded since app state is retained when navigating back and forth between apps. If you created a pinned filter in between visits to Discover, it will get removed when the saved query is reloaded.

This issue made me reconsider our previous decision. I think pinned filters should not be affected by loading or clearing a saved query, since they are pinned they should only be removed if the user explicitly asks for it. This solves the reported issue and I also think it makes the UI more intuitive.
    Matt Bargar committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    8ca25c4 View commit details
    Browse the repository at this point in the history