Retain pinned filters when loading and clearing saved queries #54307

Bargs · 2020-01-08T21:59:40Z

Summary

When we originally implemented Saved Queries we had them overwrite pinned filters on load and on clear. This caused the issue in #53258. If you have a saved query loaded in Discover for example and you navigate to a different app and then back to Discover, that saved query will get get reloaded since app state is retained when navigating back and forth between apps. If you created a pinned filter in between visits to Discover, it will get removed when the saved query is reloaded.

This issue made me reconsider our previous decision. I think pinned filters should not be affected by loading or clearing a saved query, since they are pinned they should only be removed if the user explicitly asks for it. This solves the reported issue and I also think it makes the UI more intuitive.

I updated this for Discover, Visualize, Dashboard, Lens, and Maps.

@XavierM I looked at SIEM but it wasn't clear to me if you use global state and pinned filters at all. Do you?

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~

Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~

This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2020-01-08T21:59:43Z

Pinging @elastic/kibana-app (Team:KibanaApp)

nreese

lgtm for Maps changes
code review, tested in chrome

XavierM · 2020-01-08T23:00:27Z

@Bargs I would have to add the global filter, I like the way you did it. if you interested, I can show you where we should add that.

Bargs · 2020-01-09T21:09:20Z

@XavierM ok so you don't use global filters at the moment? In other words, there's nothing I should update for SIEM in this PR?

Bargs · 2020-01-16T23:01:16Z

x-pack/legacy/plugins/lens/public/app_plugin/app.tsx

@@ -239,7 +239,9 @@ export function App({
                setState(s => ({ ...s, savedQuery }));
              }}
              onSavedQueryUpdated={savedQuery => {
-                data.query.filterManager.setFilters(savedQuery.attributes.filters || state.filters);


@wylieconlon do you mind looking at the Lens changes to make sure I didn't screw anything up? It's just this file and the test file above.

Bargs · 2020-01-17T21:15:07Z

@TinaHeiligers do you think you'd have bandwidth to review this next week?

TinaHeiligers · 2020-01-17T22:15:08Z

I'll try! Christiane (Tina) Heiligers

…

On Fri, Jan 17, 2020 at 2:15 PM Matt Bargar ***@***.***> wrote: @TinaHeiligers <https://github.com/TinaHeiligers> do you think you'd have bandwidth to review this next week? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54307?email_source=notifications&email_token=AC23SSW625RWLUEVKPEIGP3Q6INV3A5CNFSM4KEPFTVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJI7SVI#issuecomment-575797589>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC23SSSYIJZSVMGXYUKOM6LQ6INV3ANCNFSM4KEPFTVA> .

TinaHeiligers

The code looks good and the fix works locally.
LGTM

Bargs · 2020-01-21T19:39:10Z

@elasticmachine merge upstream

kibanamachine · 2020-01-21T21:00:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9feacd1

History

💚 Build #20977 succeeded e103a70
💔 Build #18860 failed 40a1f75

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…c#54307) When we originally implemented Saved Queries we had them overwrite pinned filters on load and on clear. This caused the issue in elastic#53258. If you have a saved query loaded in Discover for example and you navigate to a different app and then back to Discover, that saved query will get get reloaded since app state is retained when navigating back and forth between apps. If you created a pinned filter in between visits to Discover, it will get removed when the saved query is reloaded. This issue made me reconsider our previous decision. I think pinned filters should not be affected by loading or clearing a saved query, since they are pinned they should only be removed if the user explicitly asks for it. This solves the reported issue and I also think it makes the UI more intuitive.

* master: (38 commits) [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209) [SIEM][Detection Engine] Tags being turned into null rules part deux (elastic#55507) [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357) [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488) [SIEM] Detections create prepackage rules (elastic#55403) [Reporting] Convert CSV Export libs to Typescript (elastic#55117) [Maps] show field type icons in data driven styling field select (elastic#55166) Adds event log for actions and alerting (elastic#45081) [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud remove incorrect config (elastic#55427) Retain pinned filters when loading and clearing saved queries (elastic#54307) Resolver zoom, pan, and center controls (elastic#55221) Skip failing endpoint saga tests [skip-ci] Update migration guide to add rendering service example (elastic#54744) [DOCS] Updates to heat map page (elastic#55097) [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245) [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292) [Uptime] Handle locations with names but no geo data (elastic#55234) ...

#55473) When we originally implemented Saved Queries we had them overwrite pinned filters on load and on clear. This caused the issue in #53258. If you have a saved query loaded in Discover for example and you navigate to a different app and then back to Discover, that saved query will get get reloaded since app state is retained when navigating back and forth between apps. If you created a pinned filter in between visits to Discover, it will get removed when the saved query is reloaded. This issue made me reconsider our previous decision. I think pinned filters should not be affected by loading or clearing a saved query, since they are pinned they should only be removed if the user explicitly asks for it. This solves the reported issue and I also think it makes the UI more intuitive.

Bargs added 4 commits January 8, 2020 16:07

Retain pinned filters when loading a saved query

9290637

Retain pinned filters when clearing a saved query

0c21103

Same for maps

c223fa4

Same for lens

40a1f75

Bargs added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.6.0 labels Jan 8, 2020

Bargs requested review from TinaHeiligers and a team January 8, 2020 21:59

Bargs requested a review from a team as a code owner January 8, 2020 21:59

nreese approved these changes Jan 8, 2020

View reviewed changes

Bargs added v7.7.0 and removed v7.6.0 labels Jan 15, 2020

Matt Bargar added 2 commits January 16, 2020 17:11

Merge remote-tracking branch 'upstream/master' into disappearingPins

df60578

Fix Lens and update test to verify behaviour with pinned filters

e103a70

Bargs commented Jan 16, 2020

View reviewed changes

TinaHeiligers approved these changes Jan 17, 2020

View reviewed changes

Merge branch 'master' into disappearingPins

9feacd1

Bargs merged commit 8845608 into elastic:master Jan 21, 2020

Bargs mentioned this pull request Jan 21, 2020

[7.x] Retain pinned filters when loading and clearing saved queries (#54307) #55473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retain pinned filters when loading and clearing saved queries #54307

Retain pinned filters when loading and clearing saved queries #54307

Bargs commented Jan 8, 2020

elasticmachine commented Jan 8, 2020

nreese left a comment

XavierM commented Jan 8, 2020 •

edited

Loading

Bargs commented Jan 9, 2020

Bargs Jan 16, 2020

Bargs commented Jan 17, 2020

TinaHeiligers commented Jan 17, 2020 via email

TinaHeiligers left a comment

Bargs commented Jan 21, 2020

kibanamachine commented Jan 21, 2020

Retain pinned filters when loading and clearing saved queries #54307

Retain pinned filters when loading and clearing saved queries #54307

Conversation

Bargs commented Jan 8, 2020

Summary

Checklist

For maintainers

elasticmachine commented Jan 8, 2020

nreese left a comment

Choose a reason for hiding this comment

XavierM commented Jan 8, 2020 • edited Loading

Bargs commented Jan 9, 2020

Bargs Jan 16, 2020

Choose a reason for hiding this comment

Bargs commented Jan 17, 2020

TinaHeiligers commented Jan 17, 2020 via email

TinaHeiligers left a comment

Choose a reason for hiding this comment

Bargs commented Jan 21, 2020

kibanamachine commented Jan 21, 2020

💚 Build Succeeded

History

XavierM commented Jan 8, 2020 •

edited

Loading