Fix maybe behavior with object type

[joshdover]

Summary

Fixes #55966

This makes a couple fundamental changes to how ObjectType and MaybeType work in conjunction with one another.

• First, it makes the default option with schema.maybe actually be undefined rather than calling Joi's default() method which does something else -- populates the default options for all subkeys of an object.
• Second, it adds a applyDefaults option to schema.object that is true by default. This will automatically populate the subkeys of the object if nothing is defined for that key on the input. If the key does not have a default, the validation will fail. applyDefaults is true by default, but can be toggled false if this behavior is not desired in some cases.

This aligns the functionality to be more similar to Joi and what developers tend to expect to happen. I did have to correct a handful of existing config schemas, but as far as I can tell, this improved their readability.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: a60a464

History

• 💛 Build #24781 was flaky 469b572
• 💔 Build #24435 failed 32c974f
• 💔 Build #24409 failed 81cdfde
• 💔 Build #22524 failed ebfa702

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[pmuellr]

the changes to event_log LGTM

[joshdover]

@elasticmachine merge upstream

[joshdover]

@elasticmachine merge upstream

[joshdover]

@elasticmachine retest

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 0a7fb50

History

• 💚 Build #25955 succeeded e4acae9
• 💚 Build #25734 succeeded bb9b28d
• 💚 Build #25017 succeeded a60a464
• 💛 Build #24781 was flaky 469b572
• 💔 Build #24435 failed 32c974f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream