[7.x] Fix maybe behavior with object type (#55932) #57716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
commented
Feb 14, 2020
Comment on lines
+52
to
+55
| schema.object({ | ||
| realm: schema.maybe(schema.string()), | ||
| maxRedirectURLSize: schema.byteSize({ defaultValue: '2kb' }), | ||
| }) |
There was a problem hiding this comment.
@elastic/kibana-security FYI for some reason this was different between master and 7.x. I updated this 7.x backport to match master. The last change in master was here however the backport of that PR still had the schema.maybe. Hopefully that was intentional.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: