-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Add aws.dimensions prefix to AWS metrics in Metrics Explorer #56216
Merged
simianhacker
merged 2 commits into
elastic:master
from
simianhacker:fix-aws-metrics-explorer-group-by
Jan 29, 2020
Merged
[Metrics UI] Add aws.dimensions prefix to AWS metrics in Metrics Explorer #56216
simianhacker
merged 2 commits into
elastic:master
from
simianhacker:fix-aws-metrics-explorer-group-by
Jan 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
phillipb
approved these changes
Jan 28, 2020
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jan 29, 2020
…orer (elastic#56216) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jan 29, 2020
…orer (elastic#56216) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Metrics UI
Metrics UI feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is in response to the changes in Metricbeat elastic/beats#15245 which changes the prefix for the Cloudwatch metricset. For every AWS metric we are now going to add
aws.dimensions
prefixes to the group by fields. Ideally we would only add the relevant fields but there is not a convenient mechanism to filter that list.