Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits UI text for ML nodes and job button #60184

Merged
merged 6 commits into from
Mar 18, 2020
Merged

Edits UI text for ML nodes and job button #60184

merged 6 commits into from
Mar 18, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 14, 2020 •
edited
Loading

Summary

This PR edits UI text related to the following screenshot:

image

In particular, it fixes the capitalization of "Active ML Nodes" and removes the unnecessary word from the "Create new job" button.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lcawl lcawl added Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 14, 2020
@lcawl lcawl requested review from a team as code owners March 14, 2020 01:00
@lcawl lcawl requested a review from gchaps March 14, 2020 01:01
peteharverson
peteharverson approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Mar 16, 2020

@elasticmachine merge upstream

gchaps
gchaps approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Mar 16, 2020

@elasticmachine merge upstream

@lcawl
Copy link
Contributor Author

lcawl commented Mar 17, 2020

@elasticmachine merge upstream

bmorelli25
bmorelli25 reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<FormattedMessage/> needs to be on one line for eslint to pass.

...s/ml/public/application/explorer/components/explorer_no_jobs_found/explorer_no_jobs_found.js Outdated Show resolved Hide resolved
...s/ml/public/application/explorer/components/explorer_no_jobs_found/explorer_no_jobs_found.js Outdated Show resolved Hide resolved
lcawl and others added 2 commits March 17, 2020 13:42
@lcawl @bmorelli25
Update x-pack/plugins/ml/public/application/explorer/components/explo…
bfa7425 
…rer_no_jobs_found/explorer_no_jobs_found.js

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>
@lcawl @bmorelli25
Update x-pack/plugins/ml/public/application/explorer/components/explo…
d7e1d54 
…rer_no_jobs_found/explorer_no_jobs_found.js

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / sets the background to euiColorSuccess with a 10% alpha channel when the user starts dragging a host, but is not hovering over the data providers.timeline data providers sets the background to euiColorSuccess with a 10% alpha channel when the user starts dragging a host, but is not hovering over the data providers

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

CypressError: Timed out retrying: expected '<div.DropTargetDataProviders-btpngf-1.gngJy.drop-target-data-providers>' to have CSS property 'background' with the value 'rgba(1, 125, 115, 0.1) none repeat scroll 0% 0% / auto padding-box border-box', but the value was 'rgb(251, 252, 253) none repeat scroll 0% 0% / auto padding-box border-box'
    at cypressErr (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:149934:9)
    at throwErr (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:149867:11)
    at Object.throwErrByPath (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:149915:3)
    at retry (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:144197:19)
    at onFailFn (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:132448:16)
    at tryCatcher (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:167415:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:165351:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:165408:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:165453:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:165528:18)
    at Async../node_modules/bluebird/js/release/async.js.Async._drainQueue (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:162140:16)
    at Async../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:162150:10)
    at Async.drainQueues (http://elastic:changeme@localhost:61121/__cypress/runner/cypress_runner.js:162024:14)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit c1435db into elastic:master Mar 18, 2020
@lcawl lcawl deleted the ml-job-mgmt branch March 18, 2020 01:16
lcawl added a commit to lcawl/kibana that referenced this pull request Mar 18, 2020
@lcawl @elasticmachine @bmorelli25
Edits UI text for ML nodes and job button (elastic#60184)
a09dedd 
* Edits UI text for ML nodes and job button

* Update x-pack/plugins/ml/public/application/explorer/components/explorer_no_jobs_found/explorer_no_jobs_found.js

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>

* Update x-pack/plugins/ml/public/application/explorer/components/explorer_no_jobs_found/explorer_no_jobs_found.js

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
@lcawl lcawl mentioned this pull request Mar 18, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 18, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
ff45d00 
* master:
  [ML] Re-enabling file upload telemetry (elastic#60418)
  [NP] Use local helper shortenDottedString for discover (elastic#60271)
  [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246)
  Task/host enhancements (elastic#59671)
  [Search service] Asynchronous ES search strategy (elastic#53538)
  Index Action - Moved index params fields to connector config (elastic#60349)
  Edits UI text for ML nodes and job button (elastic#60184)
  Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191)
  Disabled edit alert button on management ui for non registered UI alert types (elastic#60439)
  Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)"
  [Console] Fix bool filter autocompletions and refactor (elastic#60361)
  Update ingest management team handle (elastic#60457)
  [IM] Use EuiCodeBlock to render index mapping (elastic#60420)
  Add additional safeguards for data source wizard step 2 (elastic#60426)
  [kbn/pm] don't fail when plugins are outside repo (elastic#60164)
  upgrade react-use (elastic#60427)
  Remove link to old settings (elastic#60326)
  Update app arch CODEOWNERS items. (elastic#60396)
  [ML] Fixing custom urls to dashboards (elastic#60355)
  Update the ems-client dependency to 7.7.0 (elastic#59936)
lcawl added a commit that referenced this pull request Mar 18, 2020
@lcawl @bmorelli25
Edits UI text for ML nodes and job button (#60184) (#60465)
e2ab1cd 
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 19, 2020
@gmmorris
rge branch 'alerting/tls-warning' of github.com:gmmorris/kibana into …
38c5e1e 
…alerting/tls-warning

* 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (elastic#60072)
  [Uptime] replace fetch with kibana http (elastic#59881)
  Upgrade @types/node to match Node.js runtime (elastic#60368)
  [License Management] NP migration (elastic#60250)
  Fix create alert button from not showing in alerts list (elastic#60444)
  [SIEM][Case] Update connector through flyout (elastic#60307)
  add data-test-subj where possible on SO management table (elastic#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406)
  [ML] Re-enabling file upload telemetry (elastic#60418)
  [NP] Use local helper shortenDottedString for discover (elastic#60271)
  [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246)
  Task/host enhancements (elastic#59671)
  [Search service] Asynchronous ES search strategy (elastic#53538)
  Index Action - Moved index params fields to connector config (elastic#60349)
  Edits UI text for ML nodes and job button (elastic#60184)
  Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191)
  Disabled edit alert button on management ui for non registered UI alert types (elastic#60439)
  Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)"
  [Console] Fix bool filter autocompletions and refactor (elastic#60361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lcawl @kibanamachine @bmorelli25 @peteharverson @gchaps @elasticmachine