Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index Action - Moved index params fields to connector config #60349

Merged
merged 8 commits into from
Mar 18, 2020
Merged

Index Action - Moved index params fields to connector config #60349

merged 8 commits into from
Mar 18, 2020

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Mar 17, 2020 •
edited
Loading

Resolve #58892

Delete any items that are not applicable to this PR.

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Feature:UIActions UI actions. These are client side only, not related to the server side actions.. Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 17, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner March 17, 2020 03:04
@YulNaumenko YulNaumenko self-assigned this Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko
Merge remote-tracking branch 'upstream/master' into actions-index-act…
6798c29 
…ion-type-ui-changes

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@YulNaumenko
Fixed type check issue
e8a39a3
@YulNaumenko
Fixing functional tests
8ab5781
@mikecote mikecote self-requested a review March 17, 2020 12:59
mikecote
mikecote approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments / questions.

x-pack/plugins/actions/server/builtin_action_types/es_index.ts Outdated Show resolved Hide resolved
x-pack/plugins/actions/server/builtin_action_types/es_index.ts Outdated Show resolved Hide resolved
.../plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx Outdated Show resolved Hide resolved
.../plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx Outdated Show resolved Hide resolved
.../plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx Outdated Show resolved Hide resolved
pmuellr
pmuellr approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Loaded the PR to test, love being able to choose the index and time field via pickers! There's some kind of odd behavior when you try to edit the index, after having picked one (click the x to delete, but it doesn't go away), but we can fix that in a separate issue - not a blocker.

x-pack/plugins/actions/server/builtin_action_types/es_index.ts Outdated Show resolved Hide resolved
x-pack/plugins/actions/server/builtin_action_types/es_index.test.ts Show resolved Hide resolved
x-pack/plugins/actions/server/builtin_action_types/es_index.test.ts
// minimal params, index via config and param
config = { index: 'index-via-config' };
// minimal params
config = { index: 'index-value', executionTimeField: undefined, refresh: false };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal params would just be index, since executionTimeField is maybe, and refresh has a default value

@YulNaumenko
Fixed due to comments
eba4f70
@YulNaumenko
Fixed functional tests
935d8e0
@YulNaumenko
Fixed tests and type check
00e8703
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into actions-index-act…
1c07847 
…ion-type-ui-changes

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@YulNaumenko YulNaumenko merged commit 2207e0a into elastic:master Mar 18, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 18, 2020
@YulNaumenko
Index Action - Moved index params fields to connector config (elastic…
82f0db5 
…#60349)

* Moved index params fields to connector config

* Fixed type check issue

* Fixing functional tests

* Fixed due to comments

* Fixed functional tests

* Fixed tests and type check
@YulNaumenko YulNaumenko mentioned this pull request Mar 18, 2020
Closed
@kibanamachine
Copy link
Contributor

💔 Build Failed

Test Failures

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running 'yarn test:karma' should exit 0

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/59226

Stack Trace

Error: Command failed with exit code 3: yarn test:karma
    at makeError (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/lib/error.js:56:11)
    at handlePromise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/index.js:114:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 18, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
ff45d00 
* master:
  [ML] Re-enabling file upload telemetry (elastic#60418)
  [NP] Use local helper shortenDottedString for discover (elastic#60271)
  [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246)
  Task/host enhancements (elastic#59671)
  [Search service] Asynchronous ES search strategy (elastic#53538)
  Index Action - Moved index params fields to connector config (elastic#60349)
  Edits UI text for ML nodes and job button (elastic#60184)
  Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191)
  Disabled edit alert button on management ui for non registered UI alert types (elastic#60439)
  Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)"
  [Console] Fix bool filter autocompletions and refactor (elastic#60361)
  Update ingest management team handle (elastic#60457)
  [IM] Use EuiCodeBlock to render index mapping (elastic#60420)
  Add additional safeguards for data source wizard step 2 (elastic#60426)
  [kbn/pm] don't fail when plugins are outside repo (elastic#60164)
  upgrade react-use (elastic#60427)
  Remove link to old settings (elastic#60326)
  Update app arch CODEOWNERS items. (elastic#60396)
  [ML] Fixing custom urls to dashboards (elastic#60355)
  Update the ems-client dependency to 7.7.0 (elastic#59936)
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 18, 2020
@YulNaumenko
Index Action - Moved index params fields to connector config (elastic…
fe4fe3b 
…#60349)

* Moved index params fields to connector config

* Fixed type check issue

* Fixing functional tests

* Fixed due to comments

* Fixed functional tests

* Fixed tests and type check
@YulNaumenko YulNaumenko mentioned this pull request Mar 18, 2020
Merged
YulNaumenko added a commit that referenced this pull request Mar 18, 2020
@YulNaumenko
Index Action - Moved index params fields to connector config (#60349) (…
e4ae389 
…#60517)

* Moved index params fields to connector config

* Fixed type check issue

* Fixing functional tests

* Fixed due to comments

* Fixed functional tests

* Fixed tests and type check
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 19, 2020
@gmmorris
rge branch 'alerting/tls-warning' of github.com:gmmorris/kibana into …
38c5e1e 
…alerting/tls-warning

* 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (elastic#60072)
  [Uptime] replace fetch with kibana http (elastic#59881)
  Upgrade @types/node to match Node.js runtime (elastic#60368)
  [License Management] NP migration (elastic#60250)
  Fix create alert button from not showing in alerts list (elastic#60444)
  [SIEM][Case] Update connector through flyout (elastic#60307)
  add data-test-subj where possible on SO management table (elastic#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406)
  [ML] Re-enabling file upload telemetry (elastic#60418)
  [NP] Use local helper shortenDottedString for discover (elastic#60271)
  [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246)
  Task/host enhancements (elastic#59671)
  [Search service] Asynchronous ES search strategy (elastic#53538)
  Index Action - Moved index params fields to connector config (elastic#60349)
  Edits UI text for ML nodes and job button (elastic#60184)
  Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191)
  Disabled edit alert button on management ui for non registered UI alert types (elastic#60439)
  Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)"
  [Console] Fix bool filter autocompletions and refactor (elastic#60361)
  ...
@mikecote mikecote removed the release_note:skip Skip the PR/issue when compiling release notes label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Actions Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:breaking release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index Action UI - map alert context to action params
5 participants
@YulNaumenko @elasticmachine @kibanamachine @pmuellr @mikecote