Embeddable API cleanup #60207
Embeddable API cleanup #60207
Conversation
There was a problem hiding this comment.
Reviewed changes include
- Renaming some interfaces (
IEmbeddableStart-->EmbeddableStart) - Using
EmbeddableStart['getEmbeddableFactory']instead ofGetEmbeddableFactory - Making
isEditableasync - Using embeddable setup contract instead of start
- Defining dashboard plugin's start dependecies
LGTM once green
| const getStartServices = async () => { | ||
| const [coreStart, deps] = await core.getStartServices(); | ||
|
|
||
| const useHideChrome = () => { |
There was a problem hiding this comment.
I suspect this is going to be re-used in visualize and discover.
Maybe we want to put this in kibana_react?
| @@ -27,17 +27,19 @@ import { Embeddable } from './embeddable'; | |||
| import { SavedObjectIndexStore, DOC_TYPE } from '../../persistence'; | |||
| import { getEditPath } from '../../../../../../plugins/lens/common'; | |||
|
|
|||
| interface StartServices { | |||
There was a problem hiding this comment.
Not relevant for this PR, but this object is a great example of how inconsistent our naming is
xxxContract,xxxType,xxxSetup and a type with no suffix at all - in the same object :)
I guess we should choose and stick to one or two.
There was a problem hiding this comment.
agree! I called this startServices based off the naming of core.getStartServices().
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
added
the
release_note:skip
…bed-interface-cleanup
stacey-gammon
force-pushed
the
2020-03-13-embed-interface-cleanup
branch
from
52686f1
to
b81e54f
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@oatkiller - if you could take a peek, just made a change to the embeddable api so your code got touched. |
* wip * Remove test in legacy functional plugin
registerEmbeddableFactoryfrom start contractisEditableasync as that is based off capabilities which is retrieved from CoreStart, so needs to be available async.GetEmbeddableFactory/iestypescreateApisemantics, go with a simpler approach.