Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency @elastic/charts to v18.1.0 #60578

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Update dependency @elastic/charts to v18.1.0 #60578

merged 5 commits into from
Mar 20, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Mar 18, 2020 •
edited
Loading

Summary

This PR contains the following updates:

Package Type Update Change
@elastic/charts dependencies major ^17.1.1 -> ^18.1.0

For reviewers

There are few breaking changes reported in the Release Notes below.
Please note that the main breaking change is the following:

  • the <Settings /> component how hides by default the last/current value on the legend (highlighted in red in the screenshot below). I've manually added this extra value on the legend whenever I saw it wasn't disabled manually.
    Please check carefully and if you need to enable/disable that please use the showLegendExtra prop on the <Settings /> component

Screenshot 2020-03-18 at 23 56 19

Release Notes

18.1.0 (2020-03-18)

Bug Fixes

  • add unicorn eslint as dev dependency (#591) (30fd07c)

Features

18.0.0 (2020-03-17)

Code Refactoring

Features

  • cleaner color API on SeriesSpec (#571) (f769f7c)
  • legend: allow color picker component render prop (#545) (90f4b95)
  • partition: add element click, over and out events (#578) (103df02)
  • partition: add tooltip (#544) (6bf9a69), closes #246
  • percentage display in partitioning charts (#558) (d6aa8d7)
  • specify series name with a function on SeriesSpec (#539) (358455a)
  • xAccessor can be a function accessor (#574) (bcc3d63)

BREAKING CHANGES

  • The getSpecId, getGroupId, getAxisId and getAnnotationId are no longer available. Use a simple string instead.
  • customSeriesColors prop on SeriesSpec is now color. The CustomSeriesColors type is replaced with SeriesColorAccessor.
  • Remove customSubSeriesName prop on series specs in favor of cleaner api using just the name prop on SeriesSpec. The types SeriesStringPredicate, SubSeriesStringPredicate have been removed.
  • the SeriesIdentifier type is generalized into a simplified object with two values in common: specId and key. A specialized XYChartSeriesIdentifier extends now the base SeriesIdentifier.
    The SettingsSpec prop showLegendDisplayValue is renamed to showLegendExtra and its default value is now false hiding the current/last value on the legend by default.

@elastic/charts upgrade procedure

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@markov00 markov00 added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@markov00 markov00 mentioned this pull request Mar 18, 2020
Closed
1 task
@markov00 markov00 marked this pull request as ready for review March 19, 2020 14:04
@markov00 markov00 requested a review from a team as a code owner March 19, 2020 14:04
@markov00 markov00 requested a review from a team March 19, 2020 14:04
@markov00 markov00 requested review from a team as code owners March 19, 2020 14:04
wylieconlon
wylieconlon approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lens changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

YulNaumenko
YulNaumenko approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in UI - works as expected.

spalger
spalger approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbn/ui-shared-deps upgrade LGTM

weltenwort
weltenwort approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra changes LGTM

walterra
walterra approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM, also did a local test, thanks for fixing the regressions!

@markov00 markov00 requested a review from a team March 20, 2020 14:56
FrankHassanabad
FrankHassanabad approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean code changes to the SIEM code. I checked this out test ran it against our data and all the charts look to be operating.

Appreciate the process the charting team has put into place and how everyone auto updates everyone's code. Really unique and motivating for me to see this much participation and collaboration in these pull requests.

LGTM 👍

@markov00 markov00 merged commit 8861274 into elastic:master Mar 20, 2020
@markov00 markov00 mentioned this pull request Mar 20, 2020
Merged
markov00 added a commit to markov00/kibana that referenced this pull request Mar 20, 2020
@markov00
Update dependency @elastic/charts to v18.1.0 (elastic#60578)
332fc6f
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 20, 2020
@gmmorris
Merge branch 'master' into alerting/empty-list
e8c7be8 
* master: (55 commits)
  Update dependency @elastic/charts to v18.1.0 (elastic#60578)
  Only set timezone when user setting is a valid timezone (elastic#57850)
  [NP] Remove `ui/agg_types` dependencies and move paginated table to kibana_legacy (elastic#60276)
  [SIEM] Fix types in rules tests (elastic#60736)
  [Alerting] prevent flickering when fields are updated in an alert (elastic#60666)
  License checks for actions plugin (elastic#59070)
  Implemented ability to clear and properly validate alert interval (elastic#60571)
  WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568)
  [Maps] Update layer dependencies to NP (elastic#59585)
  [Discover] Remove StateManagementConfigProvider (elastic#60221)
  [ML] Listing all categorization wizard checks (elastic#60502)
  [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887)
  [SIEM] Export timeline (elastic#58368)
  [SIEM] Add support for actions and throttle in Rules (elastic#59641)
  Fix ace a11y listener (elastic#60639)
  Add addInfo toast to core notifications service (elastic#60574)
  fix test description (elastic#60638)
  [SIEM] Cypress screenshots upload to google cloud (elastic#60556)
  [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653)
  [SIEM] Fixes Modification of ML Rules (elastic#60662)
  ...
@markov00 markov00 deleted the 2020_03_18-update_elastic-charts-18.1.0 branch March 20, 2020 17:01
markov00 added a commit that referenced this pull request Mar 20, 2020
@markov00
Update dependency @elastic/charts to v18.1.0 (#60578) (#60775)
c96faa6
@peteharverson peteharverson mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

@weltenwort weltenwort weltenwort approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@spalger spalger spalger approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
10 participants
@markov00 @elasticmachine @kibanamachine @walterra @wylieconlon @weltenwort @FrankHassanabad @spalger @YulNaumenko @patrykkopycinski