[SIEM] Cases clean up Phase II #61750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if kibana config does not allow if
|
Pinging @elastic/siem (Team:SIEM) |
cnasikas
reviewed
Mar 30, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/push_to_service/index.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Mar 30, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/push_to_service/index.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Mar 30, 2020
…ad only access to our saved object in siem + manage no x-pack.security + show msg when read-only + fix reporters bug
This comment has been minimized.
This comment has been minimized.
x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/columns.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
stephmilovic
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
code review and manual testing all passed, thanks @XavierM LGTM 🚀 🎸
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Mar 31, 2020
* allow case to work without security * disable configure button + add call out if license does not match and if kibana config does not allow if * add skeleton for crud in case * fix link to timeline + disable action on case on read only + allow read only access to our saved object in siem + manage no x-pack.security + show msg when read-only + fix reporters bug * add actions required in plugins * review I * review II * review III * review IV * fix types * review V
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Mar 31, 2020
* allow case to work without security * disable configure button + add call out if license does not match and if kibana config does not allow if * add skeleton for crud in case * fix link to timeline + disable action on case on read only + allow read only access to our saved object in siem + manage no x-pack.security + show msg when read-only + fix reporters bug * add actions required in plugins * review I * review II * review III * review IV * fix types * review V
patrykkopycinski
pushed a commit
that referenced
this pull request
Mar 31, 2020
* allow case to work without security * disable configure button + add call out if license does not match and if kibana config does not allow if * add skeleton for crud in case * fix link to timeline + disable action on case on read only + allow read only access to our saved object in siem + manage no x-pack.security + show msg when read-only + fix reporters bug * add actions required in plugins * review I * review II * review III * review IV * fix types * review V
patrykkopycinski
pushed a commit
that referenced
this pull request
Mar 31, 2020
* allow case to work without security * disable configure button + add call out if license does not match and if kibana config does not allow if * add skeleton for crud in case * fix link to timeline + disable action on case on read only + allow read only access to our saved object in siem + manage no x-pack.security + show msg when read-only + fix reporters bug * add actions required in plugins * review I * review II * review III * review IV * fix types * review V
26 tasks
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary