Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move crypto to server utils #62344

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 2, 2020

Summary

Part of #62263
It's used in nodejs env only and shouldn't be imported in a browser. Now it bloats all the client-side plugins that imports anything from src/core/utils (+300 kB minified code per bundle).

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 2, 2020
@mshustov mshustov requested a review from a team as a code owner April 2, 2020 16:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov merged commit 4cb96ee into elastic:master Apr 2, 2020
@mshustov mshustov deleted the issue-62238-cleanup-imports branch April 2, 2020 19:42
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 2, 2020
* move crypto to server utils

* fix mocks
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 2, 2020
* move crypto to server utils

* fix mocks
tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 3, 2020
commit 5107ad7
Merge: 41881bc 408baf2
Author: Elastic Machine <elasticmachine@users.noreply.github.com>
Date:   Fri Apr 3 00:29:11 2020 -0400

    Merge branch 'master' into reporting/np-migration-server-config

commit 408baf2
Author: Nathan L Smith <nathan.smith@elastic.co>
Date:   Thu Apr 2 16:44:29 2020 -0500

    Allow Enterprise license for service map (elastic#62371)

    We were previously only allowing "platinum" and "trial". Change this to allow `hasAtLeast('platinum')` which includes "platinum", "enterprise", and "trial".

    Fixes elastic#62243.

commit d10889a
Author: Brandon Morelli <brandon.morelli@elastic.co>
Date:   Thu Apr 2 14:19:40 2020 -0700

    docs: updates to apm agent config (elastic#61893)

commit 2ae566e
Author: Jen Huang <its.jenetic@gmail.com>
Date:   Thu Apr 2 13:04:32 2020 -0700

    [Ingest] Fix package info request returning 500 (elastic#61712)

    * Fix 500 package info request error

    * Fix installed packages page not loading

    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

commit 4cb96ee
Author: Mikhail Shustov <restrry@gmail.com>
Date:   Thu Apr 2 21:41:56 2020 +0200

    move crypto to server utils (elastic#62344)

    * move crypto to server utils

    * fix mocks

commit 7039aba
Author: Mike Côté <mikecote@users.noreply.github.com>
Date:   Thu Apr 2 15:25:03 2020 -0400

    Start indexing documents by default (elastic#62159)

commit 6d8bdf6
Author: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
Date:   Thu Apr 2 14:59:50 2020 -0400

    [Endpoint] Update host field accordion (elastic#61878)

commit d639432
Author: Nicolas Ruflin <spam@ruflin.com>
Date:   Thu Apr 2 20:46:52 2020 +0200

    Add more definitions about Ingest Management (elastic#62049)

    This should help to explain the different terms.

    The docs directory was also renamed from epm to ingest_manager.

commit bb747ab
Author: Stacey Gammon <gammon@elastic.co>
Date:   Thu Apr 2 14:27:51 2020 -0400

    Switch to embeddable factory interface with optional override (elastic#61165)

    * wip

    * typescript map embeddable

    * More updates

    * Address code review comments and update some usages in SIEM and uptime to the new types

    * More clean up - carry over some of the SIEM types to maps for render tool tip

    * fixes

    * fixes

    * Address more review comments

    * fixes

    * fixes

    * fix jest test

    * Fix visualize embeddable

    * fixes after master merge

    * Fixes

    * Prefix variable with name "custom" to make it more obvious

    * Remove layerList from input state

    * fixes

    * Update src/plugins/dashboard/public/embeddable/dashboard_container_factory.tsx

    Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>

    * review updates

    * fixes

    * update maps readme

    Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>

commit 09f1bae
Author: Peter Schretlen <peter.schretlen@elastic.co>
Date:   Thu Apr 2 14:23:09 2020 -0400

    fix text error in diagrams (elastic#62101)

commit 74d8413
Author: Sébastien Loix <sabee77@gmail.com>
Date:   Thu Apr 2 20:14:46 2020 +0200

    [Index management] Prepare support Index template V2 format (elastic#61588)

commit d6587d7
Author: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Date:   Thu Apr 2 13:03:50 2020 -0500

    Updates dashboard images (elastic#62011)

commit 41881bc
Merge: b965d81 8b31ce0
Author: Elastic Machine <elasticmachine@users.noreply.github.com>
Date:   Mon Mar 30 18:51:56 2020 -0400

    Merge branch 'master' into reporting/np-migration-server-config

commit b965d81
Merge: 3997034 9ff8be6
Author: Elastic Machine <elasticmachine@users.noreply.github.com>
Date:   Mon Mar 30 17:19:48 2020 -0400

    Merge branch 'master' into reporting/np-migration-server-config

commit 3997034
Merge: 0414532 8d539aa
Author: Elastic Machine <elasticmachine@users.noreply.github.com>
Date:   Fri Mar 27 18:58:21 2020 -0400

    Merge branch 'master' into reporting/np-migration-server-config

commit 0414532
Merge: 412635e 878ab20
Author: Joel Griffith <joel.griffith@elastic.co>
Date:   Fri Mar 27 12:48:10 2020 -0700

    Merge remote-tracking branch 'upstream/master' into reporting/np-migration-server-config

commit 412635e
Merge: b1b2bfa 5a537d1
Author: Joel Griffith <joel.griffith@elastic.co>
Date:   Fri Mar 27 11:32:11 2020 -0700

    Merge remote-tracking branch 'upstream/master' into reporting/np-migration-server-config

commit b1b2bfa
Merge: 60220fb 9a53c08
Author: Joel Griffith <joel.griffith@elastic.co>
Date:   Thu Mar 26 09:22:52 2020 -0700

    Merge remote-tracking branch 'upstream/master' into reporting/np-migration-server-config

commit 60220fb
Author: Joel Griffith <joel.griffith@elastic.co>
Date:   Wed Mar 25 10:10:24 2020 -0700

    Revert "Revert "[Reporting/New Platform Migration] Use a new config service on server-side (elastic#55882)""

    This reverts commit 5c04d9e.
mshustov added a commit that referenced this pull request Apr 3, 2020
* move crypto to server utils

* fix mocks
mshustov added a commit that referenced this pull request Apr 3, 2020
* move crypto to server utils

* fix mocks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 3, 2020
* master:
  [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457)
  allow null for filterQuery (elastic#62310)
  [ML] call job validation endpoint with complete payload (elastic#62331)
  removing configuration from agents (elastic#62290)
  Allow Enterprise license for service map (elastic#62371)
  docs: updates to apm agent config (elastic#61893)
  [Ingest] Fix package info request returning 500 (elastic#61712)
  move crypto to server utils (elastic#62344)
  Start indexing documents by default (elastic#62159)
  [Endpoint] Update host field accordion (elastic#61878)
  Add more definitions about Ingest Management (elastic#62049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants