Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft search profiler accessibility tests #62357

Merged
merged 11 commits into from
May 7, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Apr 2, 2020

Meta issue: #51456
Sub issue: #62246

associated search profiler issue : #62531 ( closed)

@bhavyarm bhavyarm mentioned this pull request Apr 3, 2020
77 tasks
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rasroh ! These tests add some really nice functional coverage too 🎉

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review April 7, 2020 17:16
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rashmivkulkarni rashmivkulkarni added the release_note:skip Skip the PR/issue when compiling release notes label Apr 7, 2020
@rashmivkulkarni
Copy link
Contributor Author

@bhavyarm - have added the test to openClose the shard details. Plz review.

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor

bhavyarm commented May 7, 2020

LGTM. Thanks for addressing that test.

@rashmivkulkarni rashmivkulkarni merged commit 2903e2f into elastic:master May 7, 2020
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request May 7, 2020
* draft search profiler accessibility tests

* added the search profiler test , data test subjects

* unskipped the test

* added another test to open-close the shard details dropdown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rashmivkulkarni added a commit that referenced this pull request May 7, 2020
* draft search profiler accessibility tests

* added the search profiler test , data test subjects

* unskipped the test

* added another test to open-close the shard details dropdown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 8, 2020
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (259 commits)
  SavedObjects bulkCreate API should return migrationVersion and strip the type & namespace from the id (elastic#65150)
  Drilldown count tooltip (elastic#65105)
  plugins logs start with "plugins." prefix (elastic#65710)
  [ML] Fix pagination reset on search query update. (elastic#65668)
  [SIEM] Add types to the mappings objects so extra keys cannot be introduced
  [apm] Update machine learning flyout and service maps docs (elastic#65517)
  change api endpoint and throw error (elastic#65790)
  [Maps] remove SLA percentage metric (elastic#65718)
  [Reporting] APM integration for baseline performance measurements (elastic#59967)
  fix(NA): noParse regex for windows on kbn optimizer (elastic#65755)
  [ML] DFA: ensure at least one field is included in analysis before job can be created (elastic#65320)
  [Data plugin] cleanup - remove unused getRoutes / routes from indexPattern object (elastic#65683)
  Removed skip to enable test. (elastic#65575)
  [Lens] Type safe migrations (elastic#65576)
  [Canvas] Fix nav link behavior in Canvas  (elastic#65590)
  [Event log] Fix flaky test (elastic#65658)
  [Alerting] changes preconfigured actions config from array to object (elastic#65397)
  remove immediate functions from esqueue worker cycles (elastic#65375)
  [Metrics UI] Fix isAbove to only display when threshold set (elastic#65540)
  draft search profiler accessibility tests (elastic#62357)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes tests_needed v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants