[SIEM] Adds sort rules Cypress test #62700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
MadameSheema
requested review from
rylnd,
dhurley14,
FrankHassanabad,
spong and
nayyara-cropsey
|
Pinging @elastic/siem (Team:SIEM) |
dhurley14
reviewed
Apr 6, 2020
| @@ -18,6 +18,10 @@ export const DELETE_RULE_BULK_BTN = '[data-test-subj="deleteRuleBulk"]'; | |||
|
|
|||
| export const ELASTIC_RULES_BTN = '[data-test-subj="show-elastic-rules-filter-button"]'; | |||
|
|
|||
| export const FIFTH_RULE = 5; | |||
There was a problem hiding this comment.
nit: I think if this is zero-based indexing this should be renamed to SIXTH_RULE
There was a problem hiding this comment.
True!! Thx! changing it now ;)
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Apr 7, 2020
* adds 'singal detection rules' spec * adds 'Sorts by activated rules' test * implements 'Sort by activated rules' * refactors code * fixes index
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Apr 7, 2020
* adds 'singal detection rules' spec * adds 'Sorts by activated rules' test * implements 'Sort by activated rules' * refactors code * fixes index
MadameSheema
added a commit
that referenced
this pull request
Apr 7, 2020
MadameSheema
added a commit
that referenced
this pull request
Apr 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: (36 commits) [data.search.aggs] Remove service getters from agg types (elastic#61628) fixing APM internationalization (elastic#62757) fix: 🐛 correctly create error on no_matching_indices (elastic#61257) [Lens] Remove all legacy imports (elastic#62596) Add label for ace editor (elastic#62588) [ML] Show better file structure finder explanations (elastic#62316) Fix old pathes in eslintrc (elastic#62580) [Uptime] Improve Telemetry test (elastic#62428) [SIEM] Adds sort rules Cypress test (elastic#62700) [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576) fixing bug (elastic#62577) [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365) [Maps] do not show circle border when symbol size is zero (elastic#62644) [Maps] Always show current zoom level (elastic#62684) bc5 siem rules merge (elastic#62679) Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)" Fix visual tests (elastic#62660) [Telemetry] update crypto packages (elastic#62469) [DOCS] Removed references to left (elastic#60807) [Maps] Move layers to np maps (elastic#61877) ...
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are adding a test in order to check that rules can be correctly sorted.
In order to test it: