Migrate vis_type_table to kibana/new platform #63105

kertal · 2020-04-09T12:22:30Z

Summary

This PR moves the Table Visualization to kibana/new platform.

Part of #60097

elasticmachine · 2020-04-09T15:23:13Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293

Left a comment about setup/start phase usage. Also, this PR is having the same problem as #63096 (review)

flash1293 · 2020-04-14T12:40:35Z

src/plugins/vis_type_table/public/table_vis_type.ts

+    description: i18n.translate('visTypeTable.tableVisDescription', {
+      defaultMessage: 'Display values in a table',
+    }),
+    visualization: getTableVisualizationControllerClass(core, context),


Woa, good catch, I completely missed it directly imported the start contract in the old version - super helpful. It seems a bit dangerous though to move the visualization registration into start here: https://github.com/elastic/kibana/pull/63105/files#diff-381e25468de5bf2e485a1957d63c9b07R62

I followed the call stack and it seems this is just necessary because of initLocalAngular here: https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/vis_type_table/public/vis_controller.ts#L57

But the local angular is only initialized in the render function (https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/vis_type_table/public/vis_controller.ts#L63), so we can do the registration in the setup phase, pass down the CoreSetup contract and then in render get CoreStart via await coreSetup.getStartServices(). This way we are doing everything in the "right" phase

many thx @flash1293 , adapted it that way

cchaos · 2020-04-14T14:23:53Z

src/plugins/vis_type_table/public/index.scss

@@ -7,6 +7,6 @@
 //   tbvChart__legend--small
 //   tbvChart__legend-isLoading

-@import 'agg_table/index';


The styling_constants import at the top of this file is no longer necessary.

thx @cchaos, I've removed it

cchaos

SASS LGTM, thanks!

kertal · 2020-04-20T06:48:39Z

@elasticmachine merge upstream

…-platform

flash1293

Tested in chrome, everything is rendered correctly, filters still work, all tests seem to run successfully, code structure is sound. Great work, LGTM 🚀

flash1293 · 2020-04-20T14:51:51Z

src/plugins/vis_type_table/public/plugin.ts

  }

-  public start(core: CoreStart, { data }: TablePluginStartDependencies) {
+  public start(core: CoreStart, { data, visualizations }: TablePluginStartDependencies) {


unused leftover

thx! removed it!

… github.com:kertal/kibana into kertal-pr-2020-04-09-vis_type_table-kibana-platform

kibanamachine · 2020-04-21T07:41:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ebcb3aa

History

💚 Build #41780 succeeded 5bb4130
💚 Build #41556 succeeded 2b66591
💚 Build #41470 succeeded 13bc8ab
💔 Build #41459 failed a8d01bf
💔 Build #41456 failed ade3bfa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Move vis_type_table to Kibana Platform * Adapt mocha tests * Adapt CODEOWNERS * Adapt SCSS

* master: (30 commits) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) [Maps] fix date labels (elastic#63909) [TSVB] Use default Kibana palette for split series (elastic#62241) Ingest overview page (elastic#63214) ...

* Move vis_type_table to Kibana Platform * Adapt mocha tests * Adapt SCSS

…t-node-pipelines * 'master' of github.com:elastic/kibana: (32 commits) Move authz lib out of snapshot restore (#63947) Migrate vis_type_table to kibana/new platform (#63105) Enable include/exclude in Terms agg for numeric fields (#59425) follow conventions for saved object definitions (#63571) [Docs]Adds saved object key setting to load balancing kib instances (#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (#63838) Fix page layouts, clean up unused code (#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (#63859) [Maps] Do not fetch geo_shape from docvalues (#63997) Vega doc changes (#63889) [Metrics UI] Reorganize file layout for Metrics UI (#60049) Add sub-menus to Resolver node (for 75% zoom) (#63476) [FTR] Add test suite metrics tracking/output (#62515) [ML] Fixing single metric viewer page padding (#63839) [Discover] Allow user to generate a report after saving a modified saved search (#63623) [Reporting] Config flag to escape formula CSV values (#63645) [Metrics UI] Remove remaining field filtering (#63398) [Maps] fix date labels (#63909) [TSVB] Use default Kibana palette for split series (#62241) ...

…bana into ingest-node-pipelines/privileges * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits) Move authz lib out of snapshot restore (elastic#63947) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [Ingest pipelines] Delete pipeline (elastic#63635) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) [Maps] fix date labels (elastic#63909) ... # Conflicts: # x-pack/legacy/plugins/uptime/public/components/monitor/ml/index.ts # x-pack/legacy/plugins/uptime/public/components/overview/index.ts # x-pack/plugins/ingest_pipelines/public/application/index.tsx # x-pack/plugins/ingest_pipelines/server/routes/api/index.ts # x-pack/plugins/ingest_pipelines/server/routes/index.ts

…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits) [Ingest Node Pipelines] Clone Pipeline (elastic#64049) Move authz lib out of snapshot restore (elastic#63947) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [Ingest pipelines] Delete pipeline (elastic#63635) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) ...

kertal requested a review from a team April 9, 2020 12:22

kertal requested a review from a team as a code owner April 9, 2020 12:22

kertal marked this pull request as draft April 9, 2020 12:22

kertal self-assigned this Apr 9, 2020

kertal added the Feature:NP Migration label Apr 9, 2020

flash1293 mentioned this pull request Apr 9, 2020

Meta: Kibana app NP cutover #60097

Closed

69 tasks

kertal added v8.0.0 v7.8.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 9, 2020

kertal added the release_note:skip Skip the PR/issue when compiling release notes label Apr 9, 2020

kertal added 2 commits April 10, 2020 14:34

Move vis_type_table to Kibana Platform

4ec811d

Adapt mocha tests

bcc5de1

kertal force-pushed the kertal-pr-2020-04-09-vis_type_table-kibana-platform branch from f171a3a to bcc5de1 Compare April 10, 2020 13:11

kertal added 2 commits April 11, 2020 22:54

Reactivate mocha tests

a74b537

Small fix of documentation

41bdc35

kertal marked this pull request as ready for review April 12, 2020 20:48

flash1293 requested changes Apr 14, 2020

View reviewed changes

cchaos suggested changes Apr 14, 2020

View reviewed changes

kertal added 5 commits April 17, 2020 07:08

Adapt CODEOWNERS

9eb8e2d

Adapt SCSS

6498567

Address review comments

ade3bfa

Merge upstream/master, fix conflicts

a8d01bf

Fix types

13bc8ab

kertal requested review from cchaos and flash1293 April 17, 2020 07:41

cchaos approved these changes Apr 17, 2020

View reviewed changes

Apply social distancing to mocha tests, remove legacy plugin

2b66591

Merge branch 'master' into kertal-pr-2020-04-09-vis_type_table-kibana…

5bb4130

…-platform

flash1293 approved these changes Apr 20, 2020

View reviewed changes

kertal added 2 commits April 21, 2020 07:59

Remove VisualizationsStart since it's not needed

46193d1

Merge branch 'kertal-pr-2020-04-09-vis_type_table-kibana-platform' of…

ebcb3aa

… github.com:kertal/kibana into kertal-pr-2020-04-09-vis_type_table-kibana-platform

kertal merged commit 2f363ba into elastic:master Apr 21, 2020

kertal added a commit to kertal/kibana that referenced this pull request Apr 21, 2020

Migrate vis_type_table to kibana/new platform (elastic#63105)

cc60c17

* Move vis_type_table to Kibana Platform * Adapt mocha tests * Adapt CODEOWNERS * Adapt SCSS

kertal mentioned this pull request Apr 21, 2020

[7.x] Migrate vis_type_table to kibana/new platform (#63105) #64042

Merged

kertal added a commit that referenced this pull request Apr 21, 2020

Migrate vis_type_table to kibana/new platform (#63105) (#64042)

21be1c0

* Move vis_type_table to Kibana Platform * Adapt mocha tests * Adapt SCSS

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate vis_type_table to kibana/new platform #63105

Migrate vis_type_table to kibana/new platform #63105

kertal commented Apr 9, 2020 •

edited

Loading

elasticmachine commented Apr 9, 2020

flash1293 left a comment

flash1293 Apr 14, 2020

kertal Apr 17, 2020

cchaos Apr 14, 2020

kertal Apr 17, 2020

cchaos left a comment

kertal commented Apr 20, 2020

flash1293 left a comment

flash1293 Apr 20, 2020

kertal Apr 21, 2020

kibanamachine commented Apr 21, 2020

Migrate vis_type_table to kibana/new platform #63105

Migrate vis_type_table to kibana/new platform #63105

Conversation

kertal commented Apr 9, 2020 • edited Loading

Summary

elasticmachine commented Apr 9, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Apr 14, 2020

Choose a reason for hiding this comment

kertal Apr 17, 2020

Choose a reason for hiding this comment

cchaos Apr 14, 2020

Choose a reason for hiding this comment

kertal Apr 17, 2020

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

kertal commented Apr 20, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Apr 20, 2020

Choose a reason for hiding this comment

kertal Apr 21, 2020

Choose a reason for hiding this comment

kibanamachine commented Apr 21, 2020

💚 Build Succeeded

History

kertal commented Apr 9, 2020 •

edited

Loading