Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Converts utils Mocha tests to Jest #63132

Merged
merged 4 commits into from
Apr 14, 2020
Merged

[ML] Converts utils Mocha tests to Jest #63132

merged 4 commits into from
Apr 14, 2020

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Apr 9, 2020 •
edited
Loading

Summary

Converts legacy Mocha tests to Jest for some ML utility files:

  • ml/common/util/anomaly_utils.ts (also converted to TS)
  • ml/public/application/components/rule_editor/utils.js
  • ml/public/application/util/calc_auto_interval.js
  • ml/public/application/util/chart_utils.js
  • ml/public/application/util/string_utils.js (deleted guessTimeFormat function which is no longer used)

Part of #62006

Checklist

@peteharverson peteharverson requested a review from a team as a code owner April 9, 2020 15:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added review v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 9, 2020
@peteharverson peteharverson mentioned this pull request Apr 9, 2020
Closed
19 tasks
@peteharverson peteharverson self-assigned this Apr 14, 2020
darnautov
darnautov approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/plugins/ml/public/application/util/chart_utils.test.js Outdated Show resolved Hide resolved
@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@peteharverson peteharverson merged commit 3e26654 into elastic:master Apr 14, 2020
@peteharverson peteharverson deleted the ml-mocha-to-jest-tests branch April 14, 2020 16:49
@peteharverson peteharverson mentioned this pull request Apr 14, 2020
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Apr 14, 2020
@peteharverson @elasticmachine
[ML] Converts utils Mocha tests to Jest (elastic#63132)
58e4d29 
* [ML] Converts utils Mocha tests to Jest

* [ML] Remove unused imports

* [ML] Switch out enzyme mount for react testing library render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
peteharverson added a commit that referenced this pull request Apr 14, 2020
@peteharverson @elasticmachine
[ML] Converts utils Mocha tests to Jest (#63132) (#63487)
1bf8b6b 
* [ML] Converts utils Mocha tests to Jest

* [ML] Remove unused imports

* [ML] Switch out enzyme mount for react testing library render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 15, 2020
@gmmorris
Merge branch 'master' into alerting/deleted-alert-error
636ff99 
* master: (29 commits)
  Add test:jest_integration npm script (elastic#62938)
  [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548)
  [Discover] Fix broken setting of bucketInterval (elastic#62939)
  Disable adding conditions when in alert management context. (elastic#63514)
  [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432)
  adding useMemo (elastic#63504)
  [Maps] fix double fetch when filter pill is added (elastic#63024)
  [Lens] Fix missing formatting bug in "break down by" (elastic#63288)
  [SIEM] [Cases] Removed double pasted line (elastic#63507)
  [Reporting] Improve functional test steps (elastic#63259)
  [SIEM][CASE] Tests for server's configuration API (elastic#63099)
  [SIEM] [Cases] Case container unit tests (elastic#63376)
  [ML] Improving parsing of large uploaded files (elastic#62970)
  [ML] Listing global calendars on the job management page (elastic#63124)
  [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373)
  Add help text to form fields (elastic#63165)
  [ML] Converts utils Mocha tests to Jest (elastic#63132)
  [Metrics UI] Refactor With* containers to hooks (elastic#59503)
  [NP] Migrate logstash server side code to NP (elastic#63135)
  Clicking cancel in saved query save modal doesn't close it (elastic#62774)
  ...
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
@peteharverson @elasticmachine @wayneseymour
[ML] Converts utils Mocha tests to Jest (#63132)
1511ffe 
* [ML] Converts utils Mocha tests to Jest

* [ML] Remove unused imports

* [ML] Switch out enzyme mount for react testing library render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Apr 15, 2020
@peteharverson @elasticmachine @tsullivan
[ML] Converts utils Mocha tests to Jest (elastic#63132) (elastic#63487)
6ccf903 
* [ML] Converts utils Mocha tests to Jest

* [ML] Remove unused imports

* [ML] Switch out enzyme mount for react testing library render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@peteharverson peteharverson

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes review v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peteharverson @elasticmachine @kibanamachine @darnautov @alvarezmelissa87