[Reporting] Improve functional test steps #63259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
review
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
force-pushed
the
reporting/fn-test-better
branch
from
e3b81b0
to
2d45a68
Compare
tsullivan
commented
Apr 10, 2020
| log.debug('ReportingPage:initTests'); | ||
| await PageObjects.settings.navigateTo(); | ||
| await esArchiver.loadIfNeeded('../../functional/es_archives/logstash_functional'); | ||
| await esArchiver.load('reporting/historic'); |
There was a problem hiding this comment.
reporting/historic was not used for anything
tsullivan
commented
Apr 10, 2020
| await esArchiver.load('reporting/historic'); | ||
| await kibanaServer.uiSettings.replace({ | ||
| defaultIndex: 'logstash-*', | ||
| }); |
There was a problem hiding this comment.
A default index is provided by the ES Archive now
tsullivan
force-pushed
the
reporting/fn-test-better
branch
from
2d45a68
to
1c553ac
Compare
|
I've added the 7.7.0 version label, as all of these tests are still being skipped in the 7.7 branch and we'd like to re-enable them. cc @liza-mae |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
dmlemeshko
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Code LGTM. I started flaky test runner with 30 threads to check if it is stable:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/361/
Let's wait for it before merge
This was referenced Apr 14, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 14, 2020
* Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 15, 2020
* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Apr 15, 2020
* Revert "FTR: add chromium-based Edge browser support (#61684) (#63068)" This reverts commit e8caa06. * update lock file * [Reporting] Improve functional test steps (#63259) * Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * get tests to pass * get more tests to pass * reduce branch diffs * reduce loc change Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Apr 16, 2020
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR streamlines Reporting functional tests by using ES-Archiver to load saved dashboards to report against, instead of building a dashboard on-the-fly in the test.
Timing results:
BEFORE
AFTER
NOTE:
x-pack/test/reporting/functional/reports/baselinewere not used, so I removed them in this PR.