[SIEM] Fixes 'Sort by activated rules' flakiness #63331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
MadameSheema
requested review from
rylnd,
dhurley14,
FrankHassanabad,
spong and
yctercero
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Apr 13, 2020
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Apr 13, 2020
MadameSheema
added a commit
that referenced
this pull request
Apr 13, 2020
MadameSheema
added a commit
that referenced
this pull request
Apr 13, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this test originally we were checking that the the order of the activation of the rule was also the order of sorting.
After a conversation with @dhurley14 looks like the logic behind sorting, does not take into account any specific order, just perform the sorting by the activated rules, that is the reason why the test started to be flaky.
In order to fix it, we are getting the name of the first and second rule after sorting and we check that the previous activated rules names are inside those without taking into account any order.
We added also as an extra check, asserting that the first second rules, have the switch button active.