Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input_control_vis into NP #63333

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Conversation

sulemanof
Copy link
Contributor

Summary

Moving the input_control_vis plugin into NP.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof
Copy link
Contributor Author

I faced the same issue as mentioned here: #62624

the SearchSource class is exported statically, however it still relies on runtime services

and the uiSettings is appeared to be not set :

uiSettings

So I wonder if app arch team already has a workaround for that?
cc @alexwizp @lukeelmers

@sulemanof sulemanof added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0 labels Apr 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this pull request Apr 13, 2020
69 tasks
@alexwizp
Copy link
Contributor

@sulemanof please wait until #62624 will be resolved. This week this issue should be fixed

# Conflicts:
#	.github/CODEOWNERS
#	src/plugins/input_control_vis/public/control/control.test.ts
#	src/plugins/input_control_vis/public/control/control.ts
#	src/plugins/input_control_vis/public/control/create_search_source.ts
#	src/plugins/input_control_vis/public/control/list_control_factory.ts
#	src/plugins/input_control_vis/public/control/range_control_factory.ts
#	src/plugins/input_control_vis/public/input_control_fn.test.ts
#	src/plugins/input_control_vis/public/test_utils/get_search_service_mock.ts
#	src/plugins/input_control_vis/public/types.ts
#	src/plugins/input_control_vis/public/vis_controller.tsx
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof marked this pull request as ready for review April 23, 2020 14:18
@sulemanof sulemanof requested a review from a team as a code owner April 23, 2020 14:18
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SASS Lgtm

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and input control vis works as expected, LGTM

@sulemanof sulemanof merged commit 6bb7515 into elastic:master Apr 24, 2020
@sulemanof sulemanof deleted the np/input_control_vis branch April 24, 2020 08:49
sulemanof added a commit to sulemanof/kibana that referenced this pull request Apr 24, 2020
* Move input_control_vis into NP

* Change config paths

* Clean up
# Conflicts:
#	.github/CODEOWNERS
sulemanof added a commit that referenced this pull request Apr 24, 2020
* Move input_control_vis into NP

* Change config paths

* Clean up
# Conflicts:
#	.github/CODEOWNERS
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 27, 2020
…bana into ingest-node-pipeline/open-flyout-create-edit

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (116 commits)
  [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411)
  Report Deletion via UI- functional test (elastic#64031)
  Bump handlebars dependency from 4.5.3 to 4.7.6 (elastic#64402)
  [Uptime] Update TLS settings (elastic#64111)
  [alerting] removes usage of any throughout Alerting Services code (elastic#64161)
  [CANVAS] Moves notify to a canvas service (elastic#63268)
  [Canvas] Misc NP Stuff (elastic#63703)
  update apm index pattern (elastic#64232)
  Task/hostlist pagination (elastic#63722)
  [NP] Vega migration (elastic#63849)
  Move ensureDefaultIndexPattern into data plugin (elastic#63100)
  [Fleet] Fix agent status count to not include unenrolled agents (elastic#64106)
  Migrate graph_workspace saved object registration to Kibana platform (elastic#64157)
  Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (elastic#64184)
  [ML] EuiDataGrid ml/transform components. (elastic#63447)
  [ML] Moving to kibana capabilities (elastic#64057)
  Move input_control_vis into NP (elastic#63333)
  remove reference to local application service in graph (elastic#64288)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants