Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType #64193

Merged
merged 2 commits into from
Apr 24, 2020
Merged

[FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType #64193

merged 2 commits into from
Apr 24, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 22, 2020 •
edited
Loading

During FieldFormats migration to TypeScript a new type was introduced (IFieldFormatType). This was the right decision, because for some places we need a type that describes all FieldFormat classes (important: not instances of the FieldFormat class!)

But the name for this class was chosen incorrectly. First of all, this is not an interface, and we cannot use the prefix I here. I think we should make it a little easier to understand by simply renaming it FieldFormatInstanceType (in a manner to InstanceType<T> utility-type)

Also I found an issue in src/plugins/data/common/field_formats/types.ts file.
types.ts files should re-export only types. Re-export of FieldFormat was removed.

@alexwizp alexwizp self-assigned this Apr 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added this to In progress in kibana-app-arch via automation Apr 22, 2020
@alexwizp alexwizp changed the title [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanc… [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType Apr 22, 2020
@alexwizp alexwizp marked this pull request as ready for review April 22, 2020 16:39
@alexwizp alexwizp requested a review from a team as a code owner April 22, 2020 16:39
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibana-app-arch automation moved this from In progress to Review in progress Apr 23, 2020
lizozom
lizozom approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename LGTM

@alexwizp alexwizp merged commit d539977 into elastic:master Apr 24, 2020
kibana-app-arch automation moved this from Review in progress to Done in current release Apr 24, 2020
@alexwizp alexwizp mentioned this pull request Apr 24, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 24, 2020
@alexwizp @elasticmachine
[FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanc…
0f9bc37 
…eType (elastic#64193)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 24, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
7b89039 
* master: (70 commits)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  [ML] Changes transforms wizard UI text (elastic#64150)
  [Alerting] change server log action type .log to .server-log in README (elastic#64124)
  [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026)
  chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269)
  chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486)
  skip flaky suite (elastic#61173)
  skip flaky suite (elastic#62497)
  Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262)
  [eslint] no_restricted_paths config cleanup (elastic#63741)
  Add Oil Rig Icon from @elastic/maki (elastic#64364)
  [Maps] Migrate Maps embeddables to NP (elastic#63976)
  [Ingest] Data streams list page (elastic#64134)
  chore(NA): add file-loader into jest moduleNameMapper (elastic#64330)
  [DOCS] Added images to automating report generation (elastic#64333)
  [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948)
  Expose ability to check if API Keys are enabled (elastic#63454)
  [DOCS] Fixes formatting in alerting doc (elastic#64338)
  [data.search.aggs]: Create agg types function for terms agg. (elastic#63541)
  ...
alexwizp added a commit that referenced this pull request Apr 24, 2020
@alexwizp @elasticmachine
[FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanc…
69b68a9 
…eType (#64193) (#64399)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 27, 2020
@jloleysens
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
42247e2 
…bana into ingest-node-pipeline/open-flyout-create-edit

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (116 commits)
  [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411)
  Report Deletion via UI- functional test (elastic#64031)
  Bump handlebars dependency from 4.5.3 to 4.7.6 (elastic#64402)
  [Uptime] Update TLS settings (elastic#64111)
  [alerting] removes usage of any throughout Alerting Services code (elastic#64161)
  [CANVAS] Moves notify to a canvas service (elastic#63268)
  [Canvas] Misc NP Stuff (elastic#63703)
  update apm index pattern (elastic#64232)
  Task/hostlist pagination (elastic#63722)
  [NP] Vega migration (elastic#63849)
  Move ensureDefaultIndexPattern into data plugin (elastic#63100)
  [Fleet] Fix agent status count to not include unenrolled agents (elastic#64106)
  Migrate graph_workspace saved object registration to Kibana platform (elastic#64157)
  Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (elastic#64184)
  [ML] EuiDataGrid ml/transform components. (elastic#63447)
  [ML] Moving to kibana capabilities (elastic#64057)
  Move input_control_vis into NP (elastic#63333)
  remove reference to local application service in graph (elastic#64288)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@mattkime mattkime Awaiting requested review from mattkime

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels
Feature:FieldFormatters release_note:skip Skip the PR/issue when compiling release notes review v7.8.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexwizp @elasticmachine @kibanamachine @lizozom