Renamed ilm policy for event log so it is not prefixed with dot #64262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
LGTM; I tried running this, leaving ES running from before pulling the code. The new ILM policy got built, nothing seemed to be referencing it (as expected), and no unexpected log lines in es or Kibana. Also tried it after nuking my es files and restarting. Everything seemed to be pointing to the new policy name.
…ilm-policy # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 23, 2020
…tic#64262) * Renamed ilm policy for event log so it is not prefixed with dot * Fixed due to comments
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 24, 2020
* master: (70 commits) KQL removes leading zero and breaks query (elastic#62748) [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193) [ML] Changes transforms wizard UI text (elastic#64150) [Alerting] change server log action type .log to .server-log in README (elastic#64124) [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026) chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269) chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486) skip flaky suite (elastic#61173) skip flaky suite (elastic#62497) Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262) [eslint] no_restricted_paths config cleanup (elastic#63741) Add Oil Rig Icon from @elastic/maki (elastic#64364) [Maps] Migrate Maps embeddables to NP (elastic#63976) [Ingest] Data streams list page (elastic#64134) chore(NA): add file-loader into jest moduleNameMapper (elastic#64330) [DOCS] Added images to automating report generation (elastic#64333) [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948) Expose ability to check if API Keys are enabled (elastic#63454) [DOCS] Fixes formatting in alerting doc (elastic#64338) [data.search.aggs]: Create agg types function for terms agg. (elastic#63541) ...
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 24, 2020
…tic#64262) * Renamed ilm policy for event log so it is not prefixed with dot * Fixed due to comments
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 24, 2020
…tic#64262) * Renamed ilm policy for event log so it is not prefixed with dot * Fixed due to comments
YulNaumenko
added a commit
that referenced
this pull request
Apr 24, 2020
…) (#64448) * Renamed ilm policy for event log so it is not prefixed with dot * Fixed due to comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented by get the
kibanaIndexvalue and if it has a dot prefix, removed it when constructing the ILM policy name.If for some reason it doesn't have a dot prefix (since users can change it), just used that value to construct the ILM policy name.
Resolve #61494