Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest pipelines] Component integration tests #64489

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Apr 27, 2020

This PR adds component integration tests for the Ingest Node Pipelines UI.

The tests are not yet exhaustive; in particular, there is room for better coverage around the "test pipeline" functionality. However, I believe it does provide a good foundation and covers all the main components. I will open a separate PR to add any additional tests.

Screen Shot 2020-04-28 at 9 00 57 PM

Screen Shot 2020-04-28 at 9 01 49 PM

Screen Shot 2020-04-28 at 9 02 38 PM

Screen Shot 2020-04-28 at 9 03 10 PM

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management labels Apr 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth marked this pull request as ready for review April 29, 2020 01:12
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner April 29, 2020 01:12
@alisonelizabeth
Copy link
Contributor Author

/cc @cuff-links

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@alisonelizabeth
Copy link
Contributor Author

retest

1 similar comment
@alisonelizabeth
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links
Copy link
Contributor

@alisonelizabeth Reviewing this. I ran them locally and they run fine. We are looking to get more passes before merging though. Need this ran 50 times in a row and passing.

@cuff-links
Copy link
Contributor

@alisonelizabeth I am going to run it. Will link back here.

@alisonelizabeth
Copy link
Contributor Author

Since the feature branch has been merged to master, closing this PR in favor of #65316.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants