[Telemetry] Fix inconsistent search behaviour in Advanced Settings #64510
Conversation
|
Pinging @elastic/pulse (Team:Pulse) |
afharo
force-pushed
the
telemetry/fix-search-in-advanced-settings
branch
from
aec1817
to
9de64cd
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
The code looks good and the tests indicate that having telemetry.allowChangingOptInStatus:false should render the second image (without the 'No settings found' tag) from #50676.
However, when I add telemetry.allowChangingOptInStatus: false to my local kibana.dev.yml file, I still see the undesired effect:
There was a problem hiding this comment.
My original review was based off of an incorrect interpretation of what was meant by
The behaviour of the second one should be used when searching for "telemetry" while telemetry opting UI is disabled.
in #50676. I understood the second option reference to be to the images and not the listed items.
The code looks great and I tested the fix locally. The fix shows the correct search behavior:
LGTM!
* master: [ML] Changes Machine learning overview UI text (elastic#64625) [Uptime] Migrate client to New Platform (elastic#55086) Slim vis type timeseries (elastic#64631) [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
* alerting/np-migration: (64 commits) [ML] Changes Machine learning overview UI text (elastic#64625) [Uptime] Migrate client to New Platform (elastic#55086) Slim vis type timeseries (elastic#64631) [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510) removed unneeded dep and file [SIEM] Create template timeline (elastic#63136) load react component lazily in so management section (elastic#64285) Cleanup .eslingignore and add target (elastic#64617) [Ingest] Support yaml variables in datasource (elastic#64459) typescript-ify portions of src/optimize (elastic#64688) [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546) Consolidate downloading plugin bundles to bootstrap script (elastic#64685) [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230) chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292) [Maps] fix edit filter (elastic#64586) [SIEM][Detections] Adds large list support using REST endpoints Replace a number of any-ed styled(eui*) with accurate types (elastic#64555) [Endpoint] Recursive resolver children (elastic#61914) [ML] Fix new job wizard with multiple indices (elastic#64567) Use short URLs for legacy plugin deprecation warning (elastic#64540) ...
lukeelmers
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
Summary
Fix inconsistent search behaviour in Advanced Settings when
telemetry.allowChangingOptInStatus: false.Closes #50676
Fix the logic to calculate
searchTermMatchesin the Advanced Settings for the Telemetry Management section.The change is basically fixing the logic to calculate
searchTermMatchesby also taking into consideration thetelemetry.allowChangingOptInStatusflag.Checklist
Delete any items that are not applicable to this PR.
For maintainers