[Uptime] Migrate client to New Platform #55086

justinkambic · 2020-01-16T18:06:50Z

Summary

Uptime client migration is nearly complete. Once we merge this, we should be 100% migrated.

The primary part of this patch (aside from the move of nearly 500 files) is in the new plugin file where we are now importing our Kibana dependencies with core.getStartServices.

This removal of direct imports to other plugins for dependencies has caused the definition of some new props for the Uptime App. I also introduced a new context to keep reference to startup plugins. At the moment it's only using the embeddable plugin, which we're using to fetch the Maps embeddable factory.

Testing this PR

You should be able to pull this patch and run it like normal, and all the Uptime features should work without issues.

~~Code is WIP.~~

Resolves #54033.

Resolves #60915.

The goal of this patch is to migrate the remaining client and common code from the legacy directory to the NP directory, and to consume NP services.

…-to-np

elasticmachine · 2020-01-16T18:06:53Z

Pinging @elastic/uptime (Team:uptime)

… accidentally-merged files.

kibanamachine · 2020-04-02T19:26:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4b35b4e
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

History

💔 Build #38143 failed c50e949
💔 Build #38005 failed 6300206
💔 Build #37976 failed 64bc7e4
💔 Build #20906 failed 8d8e77e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic · 2020-04-27T17:05:07Z

@elasticmachine merge upstream

justinkambic · 2020-04-27T19:19:29Z

@elasticmachine merge upstream

shahzad31 · 2020-04-28T11:19:30Z

x-pack/plugins/uptime/common/constants/plugin.ts

-  DESCRIPTION: 'Uptime monitoring',
+  DESCRIPTION: i18n.translate('xpack.uptime.pluginDescription', {
+    defaultMessage: 'Uptime monitoring',
+    description: 'The description text that will be shown to users in Kibana',


We should change this default description text.

This is the text that will be shown in the feature catalogue - I changed the description a bit to reflect that. LMK if you have a recommendation.

shahzad31 · 2020-04-28T11:22:22Z

x-pack/plugins/uptime/public/components/common/charts/__tests__/duration_charts.test.tsx

@@ -7,7 +7,7 @@
 import React from 'react';
 import DateMath from '@elastic/datemath';
 import { DurationChartComponent } from '../duration_chart';
-import { MonitorDurationResult } from '../../../../../common/types';
+import { MonitorDurationResult } from '../../../../../common';


AS much as i love short imports, but i think in this case, it make sense to keep types, runtimetype and constants separate. I fully realize this impact many files in this PR, so reverting it will be quite an effort. Let me know your thoughts about this?

cc @andrewvc

No worries - I had thought we discussed using just common in the past. Are you saying you'd want it reverted for just types, or ['types', 'runtime_types']?

ahan, i must have forgotten it, for me i think keeping types and constants make more sense, but if you guys feel different, i have no objection to importing them via 'common'.

I've removed/reverted this in d77978f, 7fff70f, and 04ce6cc.

This reverts commit 159e66c.

…/kibana into uptime_migrate-client-to-np

This reverts commit 8794013.

…ore specific paths.

x-pack/plugins/uptime/common/types/index.ts

andrewvc

LGTM WFG

justinkambic · 2020-04-29T03:46:56Z

@elasticmachine merge upstream

kibanamachine · 2020-04-29T05:40:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e467d5a

History

💔 Build #43849 failed 8fc53eb
💚 Build #43838 succeeded 2c30f34
💔 Build #43797 failed 04ce6cc
💚 Build #43772 succeeded d9cd2f5
💚 Build #43517 succeeded 365b915

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [ML] Changes Machine learning overview UI text (elastic#64625) [Uptime] Migrate client to New Platform (elastic#55086) Slim vis type timeseries (elastic#64631) [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)

* alerting/np-migration: (64 commits) [ML] Changes Machine learning overview UI text (elastic#64625) [Uptime] Migrate client to New Platform (elastic#55086) Slim vis type timeseries (elastic#64631) [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510) removed unneeded dep and file [SIEM] Create template timeline (elastic#63136) load react component lazily in so management section (elastic#64285) Cleanup .eslingignore and add target (elastic#64617) [Ingest] Support yaml variables in datasource (elastic#64459) typescript-ify portions of src/optimize (elastic#64688) [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546) Consolidate downloading plugin bundles to bootstrap script (elastic#64685) [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230) chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292) [Maps] fix edit filter (elastic#64586) [SIEM][Detections] Adds large list support using REST endpoints Replace a number of any-ed styled(eui*) with accurate types (elastic#64555) [Endpoint] Recursive resolver children (elastic#61914) [ML] Fix new job wizard with multiple indices (elastic#64567) Use short URLs for legacy plugin deprecation warning (elastic#64540) ...

* Move uptime legacy server to plugins directory. * Re-add feature registration code. * Move uptime legacy server to plugins directory. * Re-add feature registration code. * Move all files. * WIP fixing things. * WIP fixing things. * WIP fixing things. * Finished fixing server. * Fix alert type registration glitch. * Remove obsolete file. * Fix unwanted revisions, uncomment previously un-migrated code, delete accidentally-merged files. * More cleanup. * Fix all non-maps unit tests. * Get functional tests working. * Delete misplaced file. * Add uptime CODEOWNERS entry. * Get map working in Uptime app on NP. * Update CODEOWNERS to remove legacy entry. * Update server imports. * Delete and clean up unused or redundant code/comments. * Move new files from legacy to NP to fix merge error. * Fix broken import. * Delete obsolete test snapshots. * Clean up imports and types, delete obsolete code. * Clean up redundant common imports. * Delete obsolete translation keys. * Add additional explicit typing to plugin class. * Combine redundant common imports. * Delete unneeded optionalPlugin entry. * Revert "Combine redundant common imports." This reverts commit 159e66c. * Update a translation description. * Revert "Clean up redundant common imports." This reverts commit 8794013. * Remove new common index file and revert imports from only common to more specific paths. * Fix broken imports in `~/x-pack/test`. * Move new file from legacy to NP location. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Move uptime legacy server to plugins directory. * Re-add feature registration code. * Move uptime legacy server to plugins directory. * Re-add feature registration code. * Move all files. * WIP fixing things. * WIP fixing things. * WIP fixing things. * Finished fixing server. * Fix alert type registration glitch. * Remove obsolete file. * Fix unwanted revisions, uncomment previously un-migrated code, delete accidentally-merged files. * More cleanup. * Fix all non-maps unit tests. * Get functional tests working. * Delete misplaced file. * Add uptime CODEOWNERS entry. * Get map working in Uptime app on NP. * Update CODEOWNERS to remove legacy entry. * Update server imports. * Delete and clean up unused or redundant code/comments. * Move new files from legacy to NP to fix merge error. * Fix broken import. * Delete obsolete test snapshots. * Clean up imports and types, delete obsolete code. * Clean up redundant common imports. * Delete obsolete translation keys. * Add additional explicit typing to plugin class. * Combine redundant common imports. * Delete unneeded optionalPlugin entry. * Revert "Combine redundant common imports." This reverts commit 159e66c. * Update a translation description. * Revert "Clean up redundant common imports." This reverts commit 8794013. * Remove new common index file and revert imports from only common to more specific paths. * Fix broken imports in `~/x-pack/test`. * Move new file from legacy to NP location. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

justinkambic · 2020-04-29T22:44:12Z

Backported to:
7.x/7.8.0 9106475
#64773

justinkambic added 9 commits January 3, 2020 09:09

Move uptime legacy server to plugins directory.

84d3941

Merge branch 'master' into uptime_migrate-server-to-np

77f0186

Re-add feature registration code.

a6caa0c

Move uptime legacy server to plugins directory.

66873c1

Re-add feature registration code.

4660e36

Move all files.

a9764c4

Merge branch 'master' into uptime_migrate-server-to-np

c5bd00f

Merge branch 'master' into uptime_migrate-server-to-np

e885abd

Merge branch 'uptime_migrate-server-to-np' into uptime_migrate-client…

8d8e77e

…-to-np

justinkambic added Feature:New Platform v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Jan 16, 2020

justinkambic self-assigned this Jan 16, 2020

justinkambic added 14 commits April 1, 2020 15:39

Merge master.

a1d53d9

Merge master.

64bc7e4

WIP fixing things.

824647c

WIP fixing things.

ab9d5c9

WIP fixing things.

b322a18

Finished fixing server.

9565e6a

Fix alert type registration glitch.

6300206

Remove obsolete file.

c50e949

Fix unwanted revisions, uncomment previously un-migrated code, delete…

5cd39dc

… accidentally-merged files.

More cleanup.

4b35b4e

Fix all non-maps unit tests.

d190e42

Get functional tests working.

ce96694

Delete misplaced file.

805661f

Merge branch 'master' into uptime_migrate-client-to-np

624c0c4

This was referenced Apr 27, 2020

Uptime client np maps #64001

Closed

[Alerting UI] Enable edit alert functionality for Uptime alert types from alerting management ui. #60915

Closed

Merge branch 'master' into uptime_migrate-client-to-np

a792b57

Merge branch 'master' into uptime_migrate-client-to-np

365b915

shahzad31 reviewed Apr 28, 2020

View reviewed changes

justinkambic added 7 commits April 28, 2020 09:49

Revert "Combine redundant common imports."

d77978f

This reverts commit 159e66c.

Update a translation description.

3b9dfb2

Merge branch 'uptime_migrate-client-to-np' of github.com:justinkambic…

d9cd2f5

…/kibana into uptime_migrate-client-to-np

Revert "Clean up redundant common imports."

7fff70f

This reverts commit 8794013.

Remove new common index file and revert imports from only common to m…

04ce6cc

…ore specific paths.

Fix broken imports in ~/x-pack/test.

4db4d9c

Merge branch 'master' into uptime_migrate-client-to-np

2c30f34

andrewvc reviewed Apr 28, 2020

View reviewed changes

x-pack/plugins/uptime/common/types/index.ts Show resolved Hide resolved

andrewvc approved these changes Apr 28, 2020

View reviewed changes

justinkambic added 3 commits April 28, 2020 14:12

Merge branch 'master' into uptime_migrate-client-to-np

8fc53eb

Merge branch 'master' into uptime_migrate-client-to-np

eaa40e9

Move new file from legacy to NP location.

b11b4e6

Merge branch 'master' into uptime_migrate-client-to-np

e467d5a

justinkambic merged commit 05f0d0a into elastic:master Apr 29, 2020

justinkambic mentioned this pull request Apr 29, 2020

[7.x] [Uptime] Migrate client to New Platform (#55086) #64773

Merged

justinkambic deleted the uptime_migrate-client-to-np branch April 29, 2020 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Migrate client to New Platform #55086

[Uptime] Migrate client to New Platform #55086

justinkambic commented Jan 16, 2020 •

edited

Loading

elasticmachine commented Jan 16, 2020

kibanamachine commented Apr 2, 2020

justinkambic commented Apr 27, 2020

justinkambic commented Apr 27, 2020

shahzad31 Apr 28, 2020

justinkambic Apr 28, 2020

shahzad31 Apr 28, 2020

justinkambic Apr 28, 2020

shahzad31 Apr 28, 2020

justinkambic Apr 28, 2020

andrewvc left a comment

justinkambic commented Apr 29, 2020

kibanamachine commented Apr 29, 2020

justinkambic commented Apr 29, 2020

[Uptime] Migrate client to New Platform #55086

[Uptime] Migrate client to New Platform #55086

Conversation

justinkambic commented Jan 16, 2020 • edited Loading

Summary

Testing this PR

elasticmachine commented Jan 16, 2020

kibanamachine commented Apr 2, 2020

💔 Build Failed

Failed CI Steps

History

justinkambic commented Apr 27, 2020

justinkambic commented Apr 27, 2020

shahzad31 Apr 28, 2020

Choose a reason for hiding this comment

justinkambic Apr 28, 2020

Choose a reason for hiding this comment

shahzad31 Apr 28, 2020

Choose a reason for hiding this comment

justinkambic Apr 28, 2020

Choose a reason for hiding this comment

shahzad31 Apr 28, 2020

Choose a reason for hiding this comment

justinkambic Apr 28, 2020

Choose a reason for hiding this comment

andrewvc left a comment

Choose a reason for hiding this comment

justinkambic commented Apr 29, 2020

kibanamachine commented Apr 29, 2020

💚 Build Succeeded

History

justinkambic commented Apr 29, 2020

justinkambic commented Jan 16, 2020 •

edited

Loading