Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alpha messaging #64692

Merged
merged 22 commits into from
Apr 29, 2020
Merged

Conversation

hbharding
Copy link
Contributor

Closes #64239

image

This PR adds an alpha badge to overview page. It also includes a link in the footer to view more details about the alpha release inside a flyout. This flyout includes links to documentation and a discuss forum. I used our url shortener service to generate a short url which we can update outside of the codebase later.

@hbharding hbharding requested a review from a team April 28, 2020 19:26
@hbharding hbharding added Ingest Management:alpha1 Group issues for ingest management alpha1 Feature:Fleet Fleet team's agent central management project labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:Fleet)

@hbharding hbharding added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Apr 28, 2020
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels Apr 28, 2020
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, mostly i18n key naming, otherwise LGTM

@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team and removed Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 28, 2020
@snide
Copy link
Contributor

snide commented Apr 28, 2020

Hey. Small one here. I think we've traditionally used two types of labels for new features. I'd suggest one or the other to keep similar to our other messaging throughout the app.

The big different between the two is that experimental features might be removed, where beta features will continue to be developed. Using an alpha designation seems weird? What is different than beta other than our confidence?

@gchaps might be able to help here.

image

image

@hbharding
Copy link
Contributor Author

Thanks @snide

@ruflin @mostlyjason So it sounds like we don't use "Alpha" in Kibana when we introduce new products/feature/plugins. Internally we've been calling this "Alpha 1", I think mainly as a way to prevent confusion about our milestones. I don't think it matters to the user whether something is "Alpha" vs "Beta", so long as we provide information that helps set expectations (which this PR does).

I'm in favor of just calling this "Beta" so we don't need to update it again for our next milestone.

image
image

hbharding and others added 5 commits April 28, 2020 17:28
…er/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>
…er/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>
…er/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>
…er/sections/overview/index.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>
@gchaps
Copy link
Contributor

gchaps commented Apr 28, 2020

Yes, beta seems correct here. Also, the content in the beta tooltip above is the standard content we use in the UI and docs.

@hbharding
Copy link
Contributor Author

hbharding commented Apr 28, 2020

Update:

image

image

Per a discussion in slack, I changed the language to be "Experimental". I don't have a strong opinion on "beta" vs "experimental". I thought the word "experimental" looked too big/ prominent inside the pill, so I opted for an icon instead.

@hbharding
Copy link
Contributor Author

@elasticmachine merge upstream

@gchaps
Copy link
Contributor

gchaps commented Apr 28, 2020

Text looks good. Please add a period (.) at the end of the sentence.

@ruflin
Copy link
Member

ruflin commented Apr 29, 2020

I expect for a beta that there is a migration path forward from one beta to an other or even to GA. This is not the case here. I'm good with experimental instead of alpha. For me the difference is an experimental feature might go away, and alpha feature doesn't, it is just not as stable yet as a beta feature.

@hbharding
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@hbharding hbharding merged commit 1106482 into elastic:master Apr 29, 2020
hbharding pushed a commit to hbharding/kibana that referenced this pull request Apr 29, 2020
* use fixed table layout

* add alpha messaging flyout

* Added alpha badge + data streams link

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/overview/index.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* remove small tags

* change messaging from alpha to experimental

* add period

* remove unused imports

* fixed i18n ids

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 30, 2020
* master: (42 commits)
  [Ingest] Allow aggent to send metadata compliant with ECS (elastic#64452)
  [Endpoint] Remove todos, urls to issues (elastic#64833)
  [Uptime] Remove hard coded value for monitor states histograms (elastic#64396)
  Feature/send feedback link (elastic#64845)
  [ML] Moving get filters capability to admin (elastic#64879)
  Remove edit alert button from alerts list (elastic#64643)
  [EPM] Handle constant_keyword type in KB index patterns and ES index templates (elastic#64876)
  [ML] Disable data frame anaylics clone button based on permission (elastic#64830)
  Dashboard url generator to preserve saved filters from destination dashboard (elastic#64767)
  add generic typings for SavedObjectMigrationFn (elastic#63943)
  Allow to define and update a defaultPath for applications (elastic#64498)
  [Event Log] add rel=primary to saved objects for query targets (elastic#64615)
  [Lens] Use a size of 5 for first string field in visualization (elastic#64726)
  [SIEM][Lists] Removes plugin dependencies, adds more unit tests, fixes more TypeScript types
  [Ingest] Edit datasource UI (elastic#64727)
  [Lens] Bind all time fields to the time picker (elastic#63874)
  [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613)
  Improve alpha messaging (elastic#64692)
  [Ingest] Allow to enable monitoring of elastic agent (elastic#63598)
  [Metrics UI] Fix alerting when a filter query is present (elastic#64575)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 1, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (90 commits)
  remove unused import
  address review feedback
  [Ingest pipelines] Cleanup (elastic#64794)
  [Ingest] Edit datasource UI (elastic#64727)
  [Lens] Bind all time fields to the time picker (elastic#63874)
  [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613)
  Improve alpha messaging (elastic#64692)
  [Ingest] Allow to enable monitoring of elastic agent (elastic#63598)
  [Metrics UI] Fix alerting when a filter query is present (elastic#64575)
  skip flaky suite (elastic#64812) (elastic#64723)
  [Maps] do not display EMS or kibana layer wizards when not configured (elastic#64554)
  [Reporting/Test] Convert functional test code to Typescript (elastic#64601)
  make inserting timestamp with navigate methods optional with default true (elastic#64655)
  [EPM] Update UI to handle package versions and updates (elastic#64689)
  Minimize dependencies required by our telemetry middleware (elastic#64665)
  [Telemetry] oss api tests (elastic#64602)
  [ML] Adding endpoint capability checks (elastic#64662)
  Update jest config for coverage (elastic#64648)
  [SIEM][NP] Fixes bug in ML signals promotion (elastic#64720)
  share single data plugin bundle (elastic#64549)
  ...
nchaulet pushed a commit that referenced this pull request May 4, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Add badge and flyout for Ingest Manager "Alpha"
8 participants