Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share single data plugin bundle #64549

Merged
merged 4 commits into from
Apr 29, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Apr 27, 2020

Share the data plugin amongst all plugins

All the [pluginId].plugin.js bundles in total:
before: 72Mb
after: 41Mb

Loaded resources
Before:
without cache: 29.8 MB transferred / 176 MB resources
with cache: 29.8 MB transferred / 176 MB resources

After:
without cache: 23 MB transferred / 130 MB resources
with cache: 526kB transferred / 130 MB resources

@mshustov
Copy link
Contributor

Tested locally, no issues found

@spalger spalger marked this pull request as ready for review April 28, 2020 16:50
@spalger spalger requested a review from a team as a code owner April 28, 2020 16:50
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.1 v7.8.0 v8.0.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

…red-data-plugin

# Conflicts:
#	src/legacy/ui/ui_render/ui_render_mixin.js
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov mentioned this pull request Apr 29, 2020
1 task
@spalger spalger merged commit 0d4cfba into elastic:master Apr 29, 2020
@spalger spalger removed the v7.7.1 label Apr 29, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 29, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 4, 2020
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (90 commits)
  remove unused import
  address review feedback
  [Ingest pipelines] Cleanup (elastic#64794)
  [Ingest] Edit datasource UI (elastic#64727)
  [Lens] Bind all time fields to the time picker (elastic#63874)
  [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613)
  Improve alpha messaging (elastic#64692)
  [Ingest] Allow to enable monitoring of elastic agent (elastic#63598)
  [Metrics UI] Fix alerting when a filter query is present (elastic#64575)
  skip flaky suite (elastic#64812) (elastic#64723)
  [Maps] do not display EMS or kibana layer wizards when not configured (elastic#64554)
  [Reporting/Test] Convert functional test code to Typescript (elastic#64601)
  make inserting timestamp with navigate methods optional with default true (elastic#64655)
  [EPM] Update UI to handle package versions and updates (elastic#64689)
  Minimize dependencies required by our telemetry middleware (elastic#64665)
  [Telemetry] oss api tests (elastic#64602)
  [ML] Adding endpoint capability checks (elastic#64662)
  Update jest config for coverage (elastic#64648)
  [SIEM][NP] Fixes bug in ML signals promotion (elastic#64720)
  share single data plugin bundle (elastic#64549)
  ...
@spalger spalger deleted the implement/shared-data-plugin branch August 18, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants