Service map anomaly indicators #64718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
approved these changes
Apr 30, 2020
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/cytoscapeOptions.ts
Outdated
Show resolved
Hide resolved
smith
force-pushed
the
nls/anomaly-ring
branch
3 times, most recently
from
6dea6f6
to
b17a119
Compare
ogupte
reviewed
May 1, 2020
Comment on lines
+28
to
+31
| max_score: Math.max( | ||
| previousValue[key]?.max_score ?? 0, | ||
| currentValue.max_score.value ?? 0 | ||
| ) |
There was a problem hiding this comment.
should we distinguish between a actual score of 0 and an unknown score?
There was a problem hiding this comment.
The things we're reducing over should always have a score, but the type allows for it being undefined, so I think it's ok.
|
Minor visual (and probably not changed in the code yet) but noticed that the selected state for the node still marks the ring as
|
sorenlouv
reviewed
May 4, 2020
sorenlouv
reviewed
May 4, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
May 4, 2020
Get an aggregation of the anomaly scores and show style the ring around the node icon.
smith
added a commit
that referenced
this pull request
May 4, 2020
|
Tested:
|
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get an aggregation of the anomaly scores and show style the ring around the node icon.
Closes #63574