Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce visTypeVega bundle size #64749

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Reduce visTypeVega bundle size #64749

merged 1 commit into from
Apr 30, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 29, 2020 •
edited
Loading

Summary

Part of :

Loads VegaParser, VegaView, VegaMapView lazily.
Reduces the plugin bundle size from 4Mb to 3Mb.
It will be -2Mb after #64549
The last remaining big thing is the legacy maps included in the bundle due-to:

kibana/src/plugins/vis_type_vega/public/plugin.ts

Line 34 in 02cbd9c

import { getKibanaMapFactoryProvider, IServiceSettings } from '../../maps_legacy/public';

For maintainers

@mshustov mshustov added chore performance Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mshustov mshustov changed the title lazy load React components + VegaParser Slim vis_type_vega js bundle Apr 29, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov marked this pull request as ready for review April 29, 2020 12:01
@mshustov mshustov requested review from flash1293 and a team April 29, 2020 12:02
flash1293
flash1293 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only code review.

@mshustov mshustov merged commit 3442c25 into elastic:master Apr 30, 2020
@mshustov mshustov deleted the slim-vis_type_vega branch April 30, 2020 17:18
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 30, 2020
@mshustov
lazy load React components + VegaParser (elastic#64749)
0478813
@mshustov mshustov mentioned this pull request Apr 30, 2020
Merged
mshustov added a commit that referenced this pull request May 1, 2020
@mshustov @elasticmachine
lazy load React components + VegaParser (#64749) (#64931)
dcf89ca 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@pgayvallet pgayvallet mentioned this pull request May 11, 2020
Closed
17 tasks
@Dosant Dosant mentioned this pull request May 11, 2020
Closed
@tylersmalley tylersmalley mentioned this pull request Mar 30, 2021
Closed
@lizozom lizozom changed the title Slim vis_type_vega js bundle Reduce visTypeVega bundle size Apr 18, 2022
@lizozom lizozom changed the title Reduce visTypeVega bundle size Reduce visTypeVega bundle size Apr 18, 2022
@lizozom lizozom mentioned this pull request Apr 18, 2022
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
chore performance release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mshustov @elasticmachine @kibanamachine @flash1293