Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Remove forgotten rules that weren't deleted #64974

Merged
merged 4 commits into from
May 4, 2020
Merged

[SIEM] Remove forgotten rules that weren't deleted #64974

merged 4 commits into from
May 4, 2020

Conversation

rw-access
Copy link
Contributor

Summary

Removed some rules that we're no longer using.
There were a few mistakes before when we did a bulk import. We forgot to account for rules that were no longer being used.

Checklist

Delete any items that are not applicable to this PR.

N/A

For maintainers

@rw-access rw-access requested review from a team as code owners April 30, 2020 22:01
@rw-access rw-access changed the title Rules cleanup [SIEM] Remove forgotten rules that weren't deleted Apr 30, 2020
@rw-access rw-access added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v8.0.0 labels Apr 30, 2020
brokensound77
brokensound77 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Great find @bm11100

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@rylnd
Remove deleted prebuilt rules from cypress ES archive (#1)
b4eea5e 
Since these are just deletions, I was able to unzip, modify the JSON,
and zip it back up.
spong
spong approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rw-access
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rw-access rw-access merged commit 9db27db into elastic:master May 4, 2020
@rw-access rw-access deleted the rules-cleanup branch May 4, 2020 17:07
This was referenced May 4, 2020
Merged
Merged
rw-access added a commit that referenced this pull request May 5, 2020
@rw-access
[SIEM] Remove forgotten rules that weren't deleted (#64974) (#65160)
0c6211a 
* Remove stray rules that should've been deleted
* Update rule.ts and tests
* Remove deleted prebuilt rules from cypress ES archive (#1)
rw-access added a commit that referenced this pull request May 5, 2020
@rw-access
[SIEM] Remove forgotten rules that weren't deleted (#64974) (#65159)
1f44c7e 
* Remove stray rules that should've been deleted
* Update rule.ts and tests
* Remove deleted prebuilt rules from cypress ES archive (#1)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@brokensound77 brokensound77 brokensound77 approved these changes

@bm11100 bm11100 bm11100 approved these changes

@randomuserid randomuserid Awaiting requested review from randomuserid

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rw-access @elasticmachine @kibanamachine @spong @brokensound77 @bm11100 @MindyRS @rylnd