-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Service maps - update anomaly info text #65499
[APM] Service maps - update anomaly info text #65499
Conversation
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we wanted a more distinct "empty state text" but I think this works well 👍
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements deletes custom element when promptedStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
@@ -90,11 +90,11 @@ const ANOMALY_DETECTION_TITLE = i18n.translate( | |||
{ defaultMessage: 'Anomaly Detection' } | |||
); | |||
|
|||
const ANOMALY_DETECTION_INFO = i18n.translate( | |||
'xpack.apm.serviceMap.anomalyDetectionPopoverInfo', | |||
const ANOMALY_DETECTION_TOOLTIP = i18n.translate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we frequently use all caps for some variables?
Tested:
|
Closes #65404 by updating text and conditionally displaying tooltip
Anomalies detected:
Anomalies not detected: