Fixes the non-legacy ES test client to work with SSL #65598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
added
v8.0.0
v7.8.0
release_note:skip
💚 Build SucceededTo update your PR or re-run it, just comment with: |
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
May 7, 2020
…lastic#65598) ## Summary Fixes the non-legacy ES test client to work with SSL. Without this if you try to migrate `siem rules` or `alerting` or `CASE` or anything else that is using SSL based tests you get this error when trying to use the non-legacy: ```ts // pull in non-legacy service for functional tests const es = getService('es'); ``` ```ts // use it somewhere where your config.ts is utilizing SSL in a functional test // ... ``` In your console you get this error: ```ts ConnectionError: self signed certificate in certificate chain at onResponse (node_modules/@elastic/elasticsearch/lib/Transport.js:205:13) at ClientRequest.request.on.err (node_modules/@elastic/elasticsearch/lib/Connection.js:98:9) at TLSSocket.socketErrorListener (_http_client.js:401:9) at emitErrorNT (internal/streams/destroy.js:91:8) at emitErrorAndCloseNT (internal/streams/destroy.js:59:3) at process._tickCallback (internal/process/next_tick.js:63:19) ``` This fixes that by adding the CA certs from test to the ES test client.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
FrankHassanabad
added a commit
that referenced
this pull request
May 7, 2020
…65598) (#65686) ## Summary Fixes the non-legacy ES test client to work with SSL. Without this if you try to migrate `siem rules` or `alerting` or `CASE` or anything else that is using SSL based tests you get this error when trying to use the non-legacy: ```ts // pull in non-legacy service for functional tests const es = getService('es'); ``` ```ts // use it somewhere where your config.ts is utilizing SSL in a functional test // ... ``` In your console you get this error: ```ts ConnectionError: self signed certificate in certificate chain at onResponse (node_modules/@elastic/elasticsearch/lib/Transport.js:205:13) at ClientRequest.request.on.err (node_modules/@elastic/elasticsearch/lib/Connection.js:98:9) at TLSSocket.socketErrorListener (_http_client.js:401:9) at emitErrorNT (internal/streams/destroy.js:91:8) at emitErrorAndCloseNT (internal/streams/destroy.js:59:3) at process._tickCallback (internal/process/next_tick.js:63:19) ``` This fixes that by adding the CA certs from test to the ES test client. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the non-legacy ES test client to work with SSL.
Without this if you try to migrate
siem rulesoralertingorCASEor anything else that is using SSL based tests you get this error when trying to use the non-legacy:In your console you get this error:
This fixes that by adding the CA certs from test to the ES test client.