Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default cert age limit value. #65918

Merged
merged 3 commits into from
May 11, 2020
Merged

Change default cert age limit value. #65918

merged 3 commits into from
May 11, 2020

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves elastic/uptime#195.

Creates a longer default age limit for TLS certificates.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 labels May 8, 2020
@justinkambic justinkambic requested a review from a team as a code owner May 8, 2020 21:19
@justinkambic justinkambic self-assigned this May 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label May 8, 2020
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Do you think it make sense to use months value of this? i guess it would be more readable.

@justinkambic
Copy link
Contributor Author

Do you think it make sense to use months value of this? i guess it would be more readable.

Do you showing the values as months, or allowing users to change the unit type? Right now we have some hardcoded d string formatting on the backend, so the values pretty much need to be in days for now. I am ++ on updating this in future versions though.

@justinkambic justinkambic merged commit 4506ca1 into elastic:master May 11, 2020
@justinkambic justinkambic mentioned this pull request May 11, 2020
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request May 11, 2020
@justinkambic
Change default cert age limit value. (elastic#65918)
934afb6 
* Change default cert age limit value.

* Refresh test snapshot.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/uptime/common/constants/settings_defaults.ts
justinkambic added a commit to justinkambic/kibana that referenced this pull request May 11, 2020
@justinkambic
Change default cert age limit value. (elastic#65918)
706f5d2 
* Change default cert age limit value.

* Refresh test snapshot.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/uptime/common/constants/settings_defaults.ts
@justinkambic justinkambic mentioned this pull request May 11, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 12, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-components
073a924 
* master: (46 commits)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (elastic#65854)
  [functional/services] import By/until from module (elastic#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (elastic#65676)
  Inspect action shows on dashboard for every chart (elastic#65998)
  Fix heigt calc in calc issue for ie11 (elastic#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (elastic#66028)
  [SIEM] [Security] unified code structure phase 0 (elastic#65965)
  [Maps] Organize layers into subfolders (elastic#65513)
  skip flaky suite (elastic#59849)
  Cleanup prefill and edit flow. (elastic#66105)
  Fix major severity service map ring colors (elastic#66124)
  [DOCS] Improves formatting in action types (elastic#65932)
  [DOCS] APM Agent config: Setting values must be string (elastic#65875)
  Change default cert age limit value. (elastic#65918)
  [DOCS] Removed saved object options (elastic#66072)
  [SIEM] [Cases] Case API tests (elastic#65777)
  Add example of of local plugin installation (elastic#65986)
  skip flaky suite (elastic#65741)
  [SIEM][Detections] Restrict ML rule modification to ML Admins (elastic#65583)
  [Reporting/Test] Add Functional test for download CSV (elastic#65401)
  ...
jloleysens added a commit that referenced this pull request May 12, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
6316956 
…ine-editor

* 'master' of github.com:elastic/kibana: (37 commits)
  [APM] Correct relative paths in scripts (#66159)
  [Uptime] Enable deselection of stale filters (#65523)
  [Drilldowns][chore] Remove some any's from components. Remove `PlaceContext` from components (#65854)
  [functional/services] import By/until from module (#66015)
  [Drilldowns][IE] fix welcome bar layout in IE (#65676)
  Inspect action shows on dashboard for every chart (#65998)
  Fix heigt calc in calc issue for ie11 (#66010)
  [Flights] Delay Bucket - Error notification on opening sample visualization (#66028)
  [SIEM] [Security] unified code structure phase 0 (#65965)
  [Maps] Organize layers into subfolders (#65513)
  skip flaky suite (#59849)
  Cleanup prefill and edit flow. (#66105)
  Fix major severity service map ring colors (#66124)
  [DOCS] Improves formatting in action types (#65932)
  [DOCS] APM Agent config: Setting values must be string (#65875)
  Change default cert age limit value. (#65918)
  [DOCS] Removed saved object options (#66072)
  [SIEM] [Cases] Case API tests (#65777)
  Add example of of local plugin installation (#65986)
  skip flaky suite (#65741)
  ...
justinkambic added a commit that referenced this pull request May 12, 2020
@justinkambic
Change default cert age limit value. (#65918) (#66134)
077b490 
* Change default cert age limit value.

* Refresh test snapshot.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/uptime/common/constants/settings_defaults.ts
justinkambic added a commit that referenced this pull request May 12, 2020
@justinkambic
Change default cert age limit value. (#65918) (#66135)
14b6813 
* Change default cert age limit value.

* Refresh test snapshot.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/uptime/common/constants/settings_defaults.ts
@justinkambic
Copy link
Contributor Author

Backported to:

@justinkambic justinkambic deleted the uptime_age-default branch May 12, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make default age limit for certs longer
4 participants
@justinkambic @elasticmachine @kibanamachine @shahzad31